[GROOVY-4161] Source locations for added default constructors are incorrect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.2
• Fix Version/s: 1.7.3, 1.8-beta-1
• Assignee: Roshan Dawrani
• Reporter: Andrew Eisenberg
• Created: 09/Apr/10 16:43
• Updated: 23/Jun/10 15:45
• Resolved: 13/Apr/10 13:11

Description

Groovy Eclipse has just upgraded to Groovy 1.7.2 from 1.7.0 and there is a change to Verifier.addDefaultConstructors() that is breaking us.

The code is now:

BlockStatement empty = new BlockStatement();
empty.setSourcePosition(node); 
ConstructorNode constructor = new ConstructorNode(ACC_PUBLIC, empty);
constructor.setSourcePosition(node);

Is there a reason why the source location for the empty blockstatement and its containing constructor is set to be the source location of the entire class?

This is breaking content assist in Groovy-Eclipse. We would prefer to have these kinds of synthetic methods not have any source location at all.

I propose to change it to this:

BlockStatement empty = new BlockStatement();
ConstructorNode constructor = new ConstructorNode(ACC_PUBLIC, empty);

(As above, but just remove the calls to "setSourcePosition".)