[GROOVY-4048] waitForProcessOutput should also waitFor internally

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.7, 1.7.0
• Fix Version/s: 1.7.1, 1.8-beta-1
• Component/s: groovy-jdk
• Environment: OS X, Ubuntu
• Flags: Patch
• Assignee: Paul King
• Reporter: Jim Jagielski
• Created: 11/Feb/10 08:32
• Updated: 07/Apr/15 19:13
• Resolved: 19/Feb/10 06:38

Description

Related to GROOVY-3796, there is a race condition where someone could use waitForProcessOutput() and then call exitValue and get an 'java.lang.IllegalThreadStateException: process hasn't exited' error, since the actual process itself hasn't terminated. This can be worked around with a process.waitForProcessOutput(); process.waitFor(), but this is confusing since waitForProcessOutput also implies that we wait for everything.

This patch adds a specific waitFor() to waitForProcessOutput()