[GROOVY-3874] Improve the caching logic in GroovyClassLoader

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.5, 1.7-beta-2
• Fix Version/s: 1.6.6, 1.7-rc-1
• Component/s: class generator
• Assignee: Roshan Dawrani
• Reporter: Roshan Dawrani
• Created: 09/Nov/09 09:21
• Updated: 09/Dec/09 18:16
• Resolved: 10/Nov/09 03:51

Description

GroovyClassLoader#parseClass(String) internally generates a dummy file name for the script text passed to it and uses that file name to cache the class it generates. It uses System.currentTimeMillis() to come up with a unique dummy file name.

However, sometimes it happens that consecutive parseClass(String) calls with different script text may take place during the same milli-second causing GCL to following to happen:

// say dummy file name is script4576677673878.groovy. The class gets cached againt this file name.
GCL#parseClass('class A {}') 

// following returns the class A because this call is happening within the same milli-sec and hence has the same file name
GCL#parseClass('class B {}')