[GROOVY-3369] Better error message for Grab parameter errors

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6
• Fix Version/s: 1.6.1, 1.7-beta-1
• Assignee: Daniel Ferrin
• Reporter: Guillaume Sauthier
• Created: 19/Feb/09 08:10
• Updated: 07/Apr/09 23:33
• Resolved: 19/Feb/09 21:03

Description

Running this:

import org.xbill.DNS.*

@Grab(group = 'dnsjava', artifact = 'dnsjava', version = '2.0.1')
def domain(name) {
    def records = new Lookup(name, Type.MX).run()
    records.each { mx ->
        println "Host $mx.target has preference $mx.priority"
    }
}

domain("gr8conf.org")

Note the mistake: I used artifact instead of module.

And I got the stacktrace below.
A nicer error message would be more friendly

BUG! exception in phase 'conversion' in source unit 'ConsoleScript9' null
at org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:805)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:466)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:281)
at groovy.lang.GroovyShell.parseClass(GroovyShell.java:590)
at groovy.lang.GroovyShell.run(GroovyShell.java:470)
at groovy.lang.GroovyShell.run(GroovyShell.java:451)
at groovy.lang.GroovyShell.run(GroovyShell.java:160)
at groovy.lang.GroovyShell$run$0.call(Unknown Source)
at groovy.ui.Console$_runScriptImpl_closure13.doCall(Console.groovy:732)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:86)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:234)
at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:272)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:892)
at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.callCurrent(PogoMetaClassSite.java:66)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:150)
at groovy.ui.Console$_runScriptImpl_closure13.doCall(Console.groovy)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:86)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:234)
at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:272)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:892)
at groovy.lang.Closure.call(Closure.java:279)
at groovy.lang.Closure.call(Closure.java:274)
at groovy.lang.Closure.run(Closure.java:355)
at java.lang.Thread.run(Thread.java:613)