[GROOVY-3264] DGM#denormalize - Mac style line breaks and empty string

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6-rc-1
• Fix Version/s: 1.6-rc-2, 1.5.8, 1.7-beta-1
• Component/s: groovy-jdk
• Environment: Groovy 1.5.8, 1.6, trunk.
• Assignee: Unassigned
• Reporter: Alexander Veit
• Created: 07/Jan/09 08:49
• Updated: 22/Jan/09 21:34
• Resolved: 16/Jan/09 03:30

Description

DGM#denormalize, in contrast to DGM#normalize, does not handle Mac style line breaks correctly. It throws an IndexOutOfBoundsException with empty strings.

Attached a patch that solves this. It does not need an import of PlatformLineWriter and throws no IOException anymore.

The patch also contains an alternative implementation of DGM#normalize it has speedup factors of 0.66 to 8 compared with the current implementation. However I don't know if it would have any practical worth to replace the current implementation.

The second patch adds tests to DefaultGroovyMethodsTest.

Additionally, I would like to discuss if DGM#normalize should really remove the last trailing linefeed.

Issue Links

• relates to: GROOVY-3246 There should be a DGM.normalize(String) method which acts like readLines().join('\n')