[GROOVY-325] Static closures have wrong owner object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-beta-5
• Fix Version/s: 1.0-beta-10
• Component/s: class generator
• Assignee: James Strachan
• Reporter: Peter Brant
• Created: 26/Mar/04 09:58
• Updated: 24/Feb/05 02:03
• Resolved: 24/Feb/05 02:03

Description

Static closures have their owner object set to the equivalent of java.lang.Class.class instead of the class they're contained in.

Example:

class Test {
static staticMethod()

{ println("hello world") }

static void main(args) {
c =

{ staticMethod() }

c()
}
}

Fails with:

Caught: groovy.lang.MissingMethodException: No such method: staticMethod for class: Test$1 with arguments: []

Patch:

Index: ClassGenerator.java
===================================================================
retrieving revision 1.175
diff -u -r1.175 ClassGenerator.java
— ClassGenerator.java 25 Mar 2004 19:29:58 -0000 1.175
+++ ClassGenerator.java 26 Mar 2004 14:52:49 -0000
@@ -1126,9 +1126,6 @@

ClassNode owner = innerClass.getOuterClass();
String ownerTypeName = owner.getName();

• if (classNode.isStaticClass() || isStaticMethod()) { - ownerTypeName = "java.lang.Class"; - }

passingClosureParams = true;
List constructors = innerClass.getDeclaredConstructors();