[GROOVY-2987] Slow leftShift GDK methods

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.6
• Fix Version/s: 1.7.4, 1.8-beta-1
• Component/s: groovy-jdk
• Assignee: Guillaume Sauthier
• Reporter: Alexander Veit
• Created: 04/Aug/08 16:18
• Updated: 22/Jul/10 17:32
• Resolved: 22/Jul/10 06:58

Description

The DGM/PDGM methods

• StringBuffer leftShift(String, Object)
• StringBuffer leftShift(StringBuffer, Object)
• StringBuilder leftShift(StringBuilder, Object)

are (up to at minimum ten times) slower than they should be. Possible faster implementations are

    public static StringBuffer leftShift(String self, Object value) {
    	final CharSequence chseq;
    	if (value instanceof CharSequence)
    		chseq = (CharSequence)value;
    	else
    		chseq = String.valueOf(value);
    	final int capacity = 2 * (self.length() + chseq.length());
        return new StringBuffer(capacity).append(self).append(chseq);
    }

    public static StringBuffer leftShift(StringBuffer self, Object value) {
    	if (value instanceof CharSequence)
    		return self.append((CharSequence)value);
    	else
    		return self.append(value);
    }

    public static StringBuilder leftShift(StringBuilder self, Object value) {
    	if (value instanceof CharSequence)
    		return self.append((CharSequence)value);
    	else
    		return self.append(value);
    }