[GROOVY-282] isCase() - static method invocation by way of InvokeHelper should be polymorphic

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-beta-4
• Fix Version/s: 1.0-JSR-5
• Environment: beta 4, on XP
• Assignee: Jochen Theodorou
• Reporter: Bing Ran
• Created: 15/Mar/04 13:18
• Updated: 01/Dec/05 17:18
• Resolved: 01/Dec/05 17:18

Description

switch (3..7)

{ case (3..7): println ' got it' break default: println "nope" }

I got "Nope".

This was due to the fact that static method invocation by way of InvokeHelper was not polymorphic but it should, shouldn't it?

I solved the issue by adding to DefaultGroovyMethods.java

// br
public static boolean isCase(IntRange caseValue, Object switchValue) {
return caseValue.equals(switchValue);
}

But I don't think this is the right solution since this solves only IntRange but not other Range types. A more serious problem is with polymorphism of InvokerHelper or the lack of it. If polymorphism works had worked, this method would have immediately matched:

public static boolean isCase(Collection caseValue, Object switchValue) {
return caseValue.contains(switchValue);
}

And this won't produce the right result since the logic inside the contains() seems ot be a little issues itslef too. I wish the genernic catch-all method

public static boolean isCase(Object caseValue, Object switchValue) {
return caseValue.equals(switchValue);
}

would match since it uses the equals() as the defalt comparator.

I added one test case in DefaultGroovyMethodsTest.java like this:

public void testIsCase()

{ IntRange ra = new IntRange(1,3); assertTrue(InvokerHelper.isCase(ra, ra)); // line 1 assertTrue(DefaultGroovyMethods.isCase(ra, ra)); // line 2 }

The line 1 invocation is not polymorphic while line 2 is.

Thus the whole issue.

Bing Ran