[GROOVY-2811] GroovyClassLoader.isSourceNewer() fails when url has spaces

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6-beta-1
• Fix Version/s: 1.7.4, 1.8-beta-1

Environment

Java Runtime Environment version: 1.6.0_04
Java Runtime Environment vendor: Sun Microsystems Inc.
Ant version: Apache Ant version 1.7.0 compiled on December 13 2006
Operating system name: Windows XP
Operating system architecture: x86
[echo] Operating system version: 5.1
[echo] Base directory: C:\arbejde\workspace2\groovy

• Assignee: Guillaume Sauthier
• Reporter: Hans Lund
• Created: 06/May/08 16:22
• Updated: 22/Jul/10 17:32
• Resolved: 21/Jul/10 18:23

Description

The GroovyClassLoader fails to recompile scripts when the script path contains spaces, as the file latest modified always return 0 (file not found).
I think this is related to Groovy-1787 issue.

As a consequence scripts cashed by a GroovyClassLoader will not be updated even if the source is replaced.

I've extended the GroovyClassLoaderTest.java with a new test method that demonstrate the issue. My guess is that this is not the proper location so someone with a better understanding that me of the project structure should properly move/refactor it.

Also as far as I can see a fix is almost trivial? within the isSorceNewer() method the filepath:

String path = source.getPath().replace('/', File.separatorChar).replace('|', ':');

should be parsed through the internal decodeFileName prior to creating the file object.

But I'm not convinced that this is the proper fix?