[GROOVY-2615] Patches for line / colum information for various AST Nodes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6-beta-1
• Fix Version/s: 1.5.6, 1.6-beta-1
• Component/s: parser
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Reto Kleeb
• Created: 22/Feb/08 04:18
• Updated: 05/Apr/15 14:43
• Resolved: 22/Apr/08 06:30

Description

as announced before (groovy-eclipse mailinglist) we created some patches for the groovy core and the grammar. The changes affect line / column information of various AST nodes, we needed to fix these four our project where we're working on a refactoring feature for groovy-eclipse.

The changes are described in our report that is available on http://sifsstud4.hsr.ch/groovy-refactoring.pdf

description of the three patch files:

coreChanges.patch:

• added method getOriginType() to the Interface "Variable.java" (Description in Chapter: 5.5.2.3 Primitive Types)
• calling setReturnType(returnType) from c'tor in "MethodNode.java", extended this method (Description in Chapter: 5.5.2.5 Dynamic Return Types)
• left expression col. infos where to long in declaration expression node (Description in Chapter: 5.5.2.1 Declaration)
• initial expression col. infos were wrong in field node (Description in Chapter: 5.5.2.2 FieldNode)
• Changed the collection in "AnnotatedNode.java" to a LinkedHashMap, this way we were able to write the annotations back in the order they we're written.

newTests.patch:

• file contains new tests to test the getOriginType() method in the class VariableExpression
• the 2nd testclass tests the DynamicReturnType information of methodNodes
• adding tests to suite

grammarChanges.patch:

• changes are described in Chapter: 5.5.1 Grammar Changes

Issue Links

• is depended upon by: GROOVY-2646 changed behaviour of isImplicitThis() in MethodCallExpression
• relates to: GROOVY-2575 getLineNumber()/getColumnNumber() on PropertyExpression always returns -1