[GROOVY-2568] Questionable code in ReflectionCache

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.2, 1.5.3, 1.5.4
• Fix Version/s: 1.5.5
• Flags: Patch
• Assignee: James P. White
• Reporter: James P. White
• Created: 01/Feb/08 16:16
• Updated: 05/Apr/15 14:44
• Resolved: 21/Feb/08 12:36

Description

I've sent this a couple times with no reply, so putting it here so it doesn't get lost.

The logic in ReflectionCache.getCachedClass is a bit suspect and has been the source of a couple bugs. Attached is a rearranged version that makes the logic clearer and slightly faster (it will never do more tests and will usually do fewer - like half as many).

In looking at the code (which is functionally identical to 1.5.3 which fixed GROOVY-2553) a question arises that indicates there is still a bug in that the case for primitive Byte.TYPE is missing. This may not be a bug of course since the test for 2553 seems to test it too, but then the question arises why Byte.TYPE is omitted since it appears in primitiveTypesMap as well as Number.byteValue() (I think it the former that is probably relevant here).

The patch is formatted for the 1_5_X branch to minimize whitespace differences rather than correct indentation.