[GROOVY-1550] Groovy Sql (or AST builder) doesn't respect bracketing of logical operators

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-JSR-6, 1.0-RC-1
• Fix Version/s: 1.1-beta-2
• Component/s: ast builder
• Environment: Windows, HSQLDB
• Assignee: Paul King
• Reporter: Jon Skeet
• Created: 06/Nov/06 16:10
• Updated: 26/Sep/07 20:29
• Resolved: 28/Jun/07 22:16

Description

Version used: both JSR-6 and the snapshot downloaded today in the Grails 0.3 snapshot.

(AST builder selected as a component on the grounds that I'm not sure whether it's in Groovy SQL or AST.)

Groovy SQL should take note of the brackets in expressions which are presumably in the AST somewhere.

For instance, DataSet.findAll

{ it.x=='zzz' && (it.y==20 || it.x=='xxx') }

should generate SQL of:

select * from Test where x = ? and (y = ? or x = ?)

but there are no brackets in the generated SQL. This means that in the attached test case, a row is found, despite the fact that it shouldn't be. (x can't be both zzz and xxx).

(Attachment isn't a JUnit test case - it's a Groovy script with a failing assertion)