[GROOVY-136] parser chokes on file names beginning with the slash symbol

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0-beta-3
• Component/s: ast builder
• Labels: ClassFormatError
• Assignee: Bob Paulin
• Reporter: Sergey Udovenko
• Created: 18/Jan/04 18:25
• Updated: 22/May/22 16:09
• Resolved: 19/Jan/04 07:14

Description

The following code will trow "java.lang.ClassFormatError: /script (Illegal Class name "/script")":

GroovyClassLoader cl = new GroovyClassLoader();
InputStream is = new ByteArrayInputStream("println('oops!')".getBytes());

cl.parseClass(is, "/script.groovy");

The problem is that method org.codehaus.groovy.ast.ModuleNode.extractClassFromFileDescription() ignores first slash in the file name producing illegal class name.

Here is the patch:

Index: groovy/groovy-core/src/main/org/codehaus/groovy/ast/ModuleNode.java
===================================================================
RCS file: /scm/cvspublic/groovy/groovy-core/src/main/org/codehaus/groovy/ast/ModuleNode.java,v
retrieving revision 1.15
diff -u -r1.15 ModuleNode.java
— groovy/groovy-core/src/main/org/codehaus/groovy/ast/ModuleNode.java 16 Jan 2004 19:17:22 -0000 1.15
+++ groovy/groovy-core/src/main/org/codehaus/groovy/ast/ModuleNode.java 18 Jan 2004 23:19:40 -0000
@@ -244,11 +244,11 @@
}
// new lets trip the path separators
idx = answer.lastIndexOf('/');

• if (idx > 0) {
  + if (idx != -1) { answer = answer.substring(idx + 1); }
  idx = answer.lastIndexOf(File.separatorChar);
  - if (idx > 0) {
  + if (idx != -1) { answer = answer.substring(idx + 1); }

  return answer;