[GROOVY-11111] MethodNode isDefault check not correct

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Component/s: Compiler
• Assignee: Unassigned
• Reporter: Jochen Theodorou
• Created: 25/Jun/23 13:14
• Updated: 26/Jun/23 12:04
• Resolved: 26/Jun/23 12:04

Description

    public boolean isDefault() {
        return (modifiers & (ACC_ABSTRACT | ACC_PUBLIC | ACC_STATIC)) == ACC_PUBLIC &&
            Optional.ofNullable(getDeclaringClass()).filter(ClassNode::isInterface).isPresent();
    }

isPresent gives true if the value represented by the option exists, but not what value it is. Here isPresent would return true even if the class node represents a class and not an interface. While this cannot happen so far unless forced, I still suggest to replace isPresent with orElse(false)