[GROOVY-10915] SC: class that provides isCase but not isNotCase

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.13
• Component/s: groovy-jdk, Static compilation
• Assignee: Eric Milles
• Reporter: Eric Milles
• Created: 24/Jan/23 18:48
• Updated: 23/Aug/23 09:05
• Resolved: 07/May/23 15:17

Description

Consider the following:

class C {
  boolean isCase(value) {
    System.out.println("C isCase"); true
  }
}
@groovy.transform.CompileStatic // comment out and C#isCase is called for all 3
void test() {
  assert 0 in new C()
  assert !!(0 in new C())
  assert !(0 !in new C())
}
test()

"x in c" and "!(x in c)" will use C's isCase method. However "x !in c" will use DGM.isNotCase(c,x) which static dispatches to DGM.isCase. The isNotCase extension methods added in Groovy 4 should probably use invokeMethod to dynamic dispatch to make use of the isCase implemented by C.

IMO it would be much simpler to ditch "isNotCase" and have "a not in b" work identically to "not(a in b)" so one cannot implement incongruent "in" and "!in" handling.  Otherwise, expected behavior could be restored by disabling GROOVY-10383 optimization when declaring class of isCase and isNotCase differ.

Issue Links

• is related to: GROOVY-10383 SC: !in compiled to ScriptBytecodeAdapter#isNotCase
• is related to: GROOVY-10909 bytecode for in, !in, !() and ?: