[GROOVY-10035] Eliminate redundant type cast

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-beta-1
• Component/s: bytecode
• Assignee: Daniel Sun
• Reporter: Eric Milles
• Created: 14/Apr/21 00:13
• Updated: 03/Feb/22 22:34
• Resolved: 16/Apr/21 04:02

Description

The ticket is to provide some suggestion to tweak the fix of GROOVY-10034 ( https://github.com/apache/groovy/pull/1556 ):

It seems that we could make the check simpler, we do not add extra checks but tweak the existing check.

Current

https://github.com/apache/groovy/blob/master/src/main/java/org/codehaus/groovy/classgen/asm/OperandStack.java#L334

        if (targetType == top) return;

Proposed

https://github.com/apache/groovy/pull/1561

if (ClassNodeUtils.isCompatibleWith(top, targetType)) return;

Issue Links

• is a clone of: GROOVY-10034 Compiler writes extra cast for Type[] to Object[]