Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.7
    • 0.7
    • gora-solr
    • None

    Description

      Add Store implementation that supports SOLR 5.x

      Attachments

        1. gora-solr5.diff
          96 kB
          Aaron Cosand

        Issue Links

          Activity

            acosand Aaron Cosand added a comment -

            add additional module that supports solr 5.x

            acosand Aaron Cosand added a comment - add additional module that supports solr 5.x
            acosand Aaron Cosand added a comment -

            sorry - trying to figure out jira

            acosand Aaron Cosand added a comment - sorry - trying to figure out jira
            lewismc Lewis John McGibbney added a comment - - edited

            No problems at all acosand thanks for logging the issue. If you plan on addressing the issue then I can assign it to you please let one of us know. Thanks

            lewismc Lewis John McGibbney added a comment - - edited No problems at all acosand thanks for logging the issue. If you plan on addressing the issue then I can assign it to you please let one of us know. Thanks
            acosand Aaron Cosand added a comment -

            was trying to upload patch when jira started refusing connections for some reason.  Still can't get in, but I've attached the patch

            From: Lewis John McGibbney (JIRA) <jira@apache.org>
            To: aaroncosand@yahoo.com
            Sent: Saturday, May 14, 2016 5:12 PM
            Subject: [jira] [Comment Edited] (GORA-477) Add support for Solr 5.x

                [ https://issues.apache.org/jira/browse/GORA-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283676#comment-15283676 ]

            Lewis John McGibbney edited comment on GORA-477 at 5/14/16 9:12 PM:
            --------------------------------------------------------------------

            No problems at all acosand thanks for logging the issue. If you plan on addressing the issue then I can assign it to you please let one of us know. Thanks

            was (Author: lewismc):
            No problems at all acosand thanks for logging the issue

            –
            This message was sent by Atlassian JIRA
            (v6.3.4#6332)

            acosand Aaron Cosand added a comment - was trying to upload patch when jira started refusing connections for some reason.  Still can't get in, but I've attached the patch From: Lewis John McGibbney (JIRA) <jira@apache.org> To: aaroncosand@yahoo.com Sent: Saturday, May 14, 2016 5:12 PM Subject: [jira] [Comment Edited] ( GORA-477 ) Add support for Solr 5.x     [ https://issues.apache.org/jira/browse/GORA-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283676#comment-15283676 ] Lewis John McGibbney edited comment on GORA-477 at 5/14/16 9:12 PM: -------------------------------------------------------------------- No problems at all acosand thanks for logging the issue. If you plan on addressing the issue then I can assign it to you please let one of us know. Thanks was (Author: lewismc): No problems at all acosand thanks for logging the issue – This message was sent by Atlassian JIRA (v6.3.4#6332)
            lewismc Lewis John McGibbney added a comment - - edited

            Hi Aaron,
            Brilliant thank you for the patch.
            You can follow the infrabot on Twitter, as it turns out snapshots VM is
            down right now so Io suspect that there is maybe an issue with the Jira
            instance or there has been a temp lockdown due to spam,
            I'll have a look at the patch later thanks Aaron

            –
            Lewis

            lewismc Lewis John McGibbney added a comment - - edited Hi Aaron, Brilliant thank you for the patch. You can follow the infrabot on Twitter, as it turns out snapshots VM is down right now so Io suspect that there is maybe an issue with the Jira instance or there has been a temp lockdown due to spam, I'll have a look at the patch later thanks Aaron – Lewis

            Hi acosand I notice that the patch is an entire new module. What about if we just upgraded gora-solr to 5.X?
            What were the major changes?

            lewismc Lewis John McGibbney added a comment - Hi acosand I notice that the patch is an entire new module. What about if we just upgraded gora-solr to 5.X? What were the major changes?
            acosand Aaron Cosand added a comment - - edited

            The API changed from 4.x to 5.x, and I am unsure if it would be backwards compatible (4.x client wasn't forward compatible hence the desire to upgrade), which is why I created a new module.  The 4.x line is pretty far out of date (6.0 is the latest release), so I have no personal qualms about dropping explicit support, but didn't want to presume.  I can redo the patch to just upgrade the existing module, of that is preferred. Let me know.

            acosand Aaron Cosand added a comment - - edited The API changed from 4.x to 5.x, and I am unsure if it would be backwards compatible (4.x client wasn't forward compatible hence the desire to upgrade), which is why I created a new module.  The 4.x line is pretty far out of date (6.0 is the latest release), so I have no personal qualms about dropping explicit support, but didn't want to presume.  I can redo the patch to just upgrade the existing module, of that is preferred. Let me know.
            githubbot ASF GitHub Bot added a comment -

            GitHub user lewismc opened a pull request:

            https://github.com/apache/gora/pull/64

            GORA-477 Add support for Solr 5.x

            This issue provides a patch for https://issues.apache.org/jira/browse/GORA-477
            This patch was contributed by Aaron Cosand

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/lewismc/gora GORA-477

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/gora/pull/64.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #64


            commit 348e020e1df6c0b3a5b8c38b220746617320fb43
            Author: Lewis John McGibbney <lewis.mcgibbney@gmail.com>
            Date: 2016-05-17T23:11:35Z

            GORA-477 Add support for Solr 5.x

            commit 32b93d8bff4fbdbe5ca65b4076d853e666e788f4
            Author: Lewis John McGibbney <lewis.mcgibbney@gmail.com>
            Date: 2016-05-17T23:12:43Z

            GORA-477 Add support for Solr 5.x


            githubbot ASF GitHub Bot added a comment - GitHub user lewismc opened a pull request: https://github.com/apache/gora/pull/64 GORA-477 Add support for Solr 5.x This issue provides a patch for https://issues.apache.org/jira/browse/GORA-477 This patch was contributed by Aaron Cosand You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/gora GORA-477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/gora/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 348e020e1df6c0b3a5b8c38b220746617320fb43 Author: Lewis John McGibbney <lewis.mcgibbney@gmail.com> Date: 2016-05-17T23:11:35Z GORA-477 Add support for Solr 5.x commit 32b93d8bff4fbdbe5ca65b4076d853e666e788f4 Author: Lewis John McGibbney <lewis.mcgibbney@gmail.com> Date: 2016-05-17T23:12:43Z GORA-477 Add support for Solr 5.x
            githubbot ASF GitHub Bot added a comment -

            Github user lewismc commented on the pull request:

            https://github.com/apache/gora/pull/64#issuecomment-219881009

            If some folks from dev@ can review then we can commit to master

            githubbot ASF GitHub Bot added a comment - Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/64#issuecomment-219881009 If some folks from dev@ can review then we can commit to master

            Thanks acosand this is brilliant

            lewismc Lewis John McGibbney added a comment - Thanks acosand this is brilliant
            hudson Hudson added a comment -

            FAILURE: Integrated in gora-trunk #1648 (See https://builds.apache.org/job/gora-trunk/1648/)
            GORA-477 Add support for Solr 5.x (lewis.mcgibbney: rev 348e020e1df6c0b3a5b8c38b220746617320fb43)

            • gora-solr-5/src/test/conf/gora-solr-mapping.xml
            • gora-solr-5/src/test/conf/gora.properties
            • gora-solr-5/src/main/java/org/apache/gora/solr/query/SolrQuery.java
            • gora-solr-5/src/test/conf/solr/collection1/core.properties
            • gora-solr-5/src/test/conf/solr/collection1/conf/solrconfig.xml
            • pom.xml
            • gora-solr-5/src/test/conf/solr/Employee/conf/lang/stopwords_en.txt
            • gora-solr-5/src/test/conf/solr/Employee/conf/synonyms.txt
            • gora-solr-5/src/test/conf/solr/WebPage/conf/schema.xml
            • gora-solr-5/src/test/conf/solr/Employee/conf/schema.xml
            • gora-solr-5/pom.xml
            • gora-solr-5/src/test/java/org/apache/gora/solr/store/TestSolrStore.java
            • gora-solr-5/src/test/conf/solr/Employee/conf/solrconfig.xml
            • gora-solr-5/src/test/conf/solr/solr.xml
            • gora-solr-5/src/test/conf/solr/WebPage/conf/synonyms.txt
            • gora-solr/pom.xml
            • gora-solr-5/src/test/conf/log4j.properties
            • gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrStore.java
            • gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolrTestDriver.java
            • gora-solr-5/src/test/conf/solr/WebPage/conf/solrconfig.xml
            • gora-solr-5/src/test/conf/solr/Employee/conf/protwords.txt
            • gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrMapping.java
            • gora-solr-5/src/test/conf/solr/Employee/conf/stopwords.txt
            • gora-solr-5/src/test/conf/solr/WebPage/conf/protwords.txt
            • gora-solr-5/src/test/conf/solr/WebPage/conf/stopwords.txt
            • gora-solr-5/src/test/conf/solr/collection1/conf/schema.xml
            • gora-solr-5/src/test/conf/solr/zoo.cfg
            • gora-solr-5/src/main/java/org/apache/gora/solr/query/SolrResult.java
            • gora-solr-5/src/test/conf/solr/WebPage/conf/lang/stopwords_en.txt
              GORA-477 Add support for Solr 5.x (lewis.mcgibbney: rev 32b93d8bff4fbdbe5ca65b4076d853e666e788f4)
            • gora-solr/pom.xml
            hudson Hudson added a comment - FAILURE: Integrated in gora-trunk #1648 (See https://builds.apache.org/job/gora-trunk/1648/ ) GORA-477 Add support for Solr 5.x (lewis.mcgibbney: rev 348e020e1df6c0b3a5b8c38b220746617320fb43) gora-solr-5/src/test/conf/gora-solr-mapping.xml gora-solr-5/src/test/conf/gora.properties gora-solr-5/src/main/java/org/apache/gora/solr/query/SolrQuery.java gora-solr-5/src/test/conf/solr/collection1/core.properties gora-solr-5/src/test/conf/solr/collection1/conf/solrconfig.xml pom.xml gora-solr-5/src/test/conf/solr/Employee/conf/lang/stopwords_en.txt gora-solr-5/src/test/conf/solr/Employee/conf/synonyms.txt gora-solr-5/src/test/conf/solr/WebPage/conf/schema.xml gora-solr-5/src/test/conf/solr/Employee/conf/schema.xml gora-solr-5/pom.xml gora-solr-5/src/test/java/org/apache/gora/solr/store/TestSolrStore.java gora-solr-5/src/test/conf/solr/Employee/conf/solrconfig.xml gora-solr-5/src/test/conf/solr/solr.xml gora-solr-5/src/test/conf/solr/WebPage/conf/synonyms.txt gora-solr/pom.xml gora-solr-5/src/test/conf/log4j.properties gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrStore.java gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolrTestDriver.java gora-solr-5/src/test/conf/solr/WebPage/conf/solrconfig.xml gora-solr-5/src/test/conf/solr/Employee/conf/protwords.txt gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrMapping.java gora-solr-5/src/test/conf/solr/Employee/conf/stopwords.txt gora-solr-5/src/test/conf/solr/WebPage/conf/protwords.txt gora-solr-5/src/test/conf/solr/WebPage/conf/stopwords.txt gora-solr-5/src/test/conf/solr/collection1/conf/schema.xml gora-solr-5/src/test/conf/solr/zoo.cfg gora-solr-5/src/main/java/org/apache/gora/solr/query/SolrResult.java gora-solr-5/src/test/conf/solr/WebPage/conf/lang/stopwords_en.txt GORA-477 Add support for Solr 5.x (lewis.mcgibbney: rev 32b93d8bff4fbdbe5ca65b4076d853e666e788f4) gora-solr/pom.xml
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/gora/pull/64

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/gora/pull/64

            People

              acosand Aaron Cosand
              acosand Aaron Cosand
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 12h
                  12h
                  Remaining:
                  Remaining Estimate - 12h
                  12h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified