[GORA-467] Flushing DataOutputStream before calling toByteArray on the underlying ByteArrayOutputStream

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.7
• Component/s: gora-core
• Assignee: Lewis John McGibbney
• Reporter: emopers
• Created: 04/Feb/16 07:22
• Updated: 05/Feb/16 06:39
• Resolved: 05/Feb/16 06:39

Description

In ./gora-core/src/test/java/org/apache/gora/util/TestWritableUtils.java

ByteArrayOutputStream bos = new ByteArrayOutputStream();
    DataOutput out = new DataOutputStream(bos);
    WritableUtils.writeProperties(out, props);
    
    DataInput in = new DataInputStream(new ByteArrayInputStream(bos.toByteArray()));

When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance,
it is recommended to flush or close the DataOutputStream before invoking the underlying instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for example at http://stackoverflow.com/questions/2984538/how-to-use-bytearrayoutputstream-and-dataoutputstream-simultaneously-java.
The patch adds a flush method before calling toByteArray().