Uploaded image for project: 'Apache Gora'
  1. Apache Gora
  2. GORA-390

Gora compiler generate wrong isDirtyXXXX method signature

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.5
    • 0.6
    • gora-compiler
    • None

    Description

      Hi,

      I think I've spotted a small issue with actual code generated by gora-compiler.

      For each field in source Avro schema, it will generate a isDirtyXXX method which have a value parameter which is not really used.
      For instance, for a content field, the following code is generated :

        public boolean isContentDirty(java.lang.CharSequence value) {
          return isDirty(6);
        }
      

      I would expect the following code to be generated instead (ie. without value parameter) :

        public boolean isContentDirty() {
          return isDirty(6);
        }
      

      Regards,

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            drazzib Damien Raude-Morvan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment