Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: plugins
    • Labels:
      None

      Description

      Assigned to Damien for karma

      This issue will track the contribution of the gora-gradle-plugin to our SCM.

      Thanks Damien Raude-Morvan, is it possible for you to create a PR adding this as a new module named gora-gradle?

      Thank you very much in advance.

        Activity

        Hide
        drazzib Damien Raude-Morvan added a comment -

        Hi,

        My actual gora-gradle plugin is built using gradle itself (dogfooding) so I'm looking for appropriate integration.
        Do you want to build plugin inside main gora buildsystem ?

        Regards,

        Show
        drazzib Damien Raude-Morvan added a comment - Hi, My actual gora-gradle plugin is built using gradle itself (dogfooding) so I'm looking for appropriate integration. Do you want to build plugin inside main gora buildsystem ? Regards,
        Hide
        lewismc Lewis John McGibbney added a comment -

        Hi Damien Raude-Morvan
        .bq Do you want to build plugin inside main gora buildsystem ?
        I don't see why not. If you could package it in to a directory called gora-gradle-plugin then we could build it alongside everything else by simply invoking a script or something after the maven build itself.

        Show
        lewismc Lewis John McGibbney added a comment - Hi Damien Raude-Morvan .bq Do you want to build plugin inside main gora buildsystem ? I don't see why not. If you could package it in to a directory called gora-gradle-plugin then we could build it alongside everything else by simply invoking a script or something after the maven build itself.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user drazzib opened a pull request:

        https://github.com/apache/gora/pull/19

        Gradle plugin for Apache Gora (GORA-330)

        I've finally took some time to offer a clean PR to merge my Gradle plugin (see GORA-330 for details).

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/Dictanova/gora GORA-330

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/gora/pull/19.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #19


        commit fd0372b64ee0e945c6214fdb88d52b247a70651f
        Author: Damien Raude-Morvan <drazzib@drazzib.com>
        Date: 2015-02-09T22:37:39Z

        Start import of Gradle plugin into Apache Gora Git


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user drazzib opened a pull request: https://github.com/apache/gora/pull/19 Gradle plugin for Apache Gora ( GORA-330 ) I've finally took some time to offer a clean PR to merge my Gradle plugin (see GORA-330 for details). You can merge this pull request into a Git repository by running: $ git pull https://github.com/Dictanova/gora GORA-330 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/gora/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit fd0372b64ee0e945c6214fdb88d52b247a70651f Author: Damien Raude-Morvan <drazzib@drazzib.com> Date: 2015-02-09T22:37:39Z Start import of Gradle plugin into Apache Gora Git
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the pull request:

        https://github.com/apache/gora/pull/19#issuecomment-73607415

        Hi @drazzib, could you create JIRA account for this PR?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the pull request: https://github.com/apache/gora/pull/19#issuecomment-73607415 Hi @drazzib, could you create JIRA account for this PR?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the pull request:

        https://github.com/apache/gora/pull/19#issuecomment-73607576

        Ah I was an idiot =P

        Never mind =)

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the pull request: https://github.com/apache/gora/pull/19#issuecomment-73607576 Ah I was an idiot =P Never mind =)
        Hide
        hsaputra Henry Saputra added a comment -

        I am not sure what is the goal of this module? To allow integration with applications that uses Gradle?

        Show
        hsaputra Henry Saputra added a comment - I am not sure what is the goal of this module? To allow integration with applications that uses Gradle?
        Hide
        drazzib Damien Raude-Morvan added a comment -

        Henry Saputra, exactly. @Dictanova we use Gradle extensively for all our modules (in-place of Maven). We don't commit geneated files into Git, so I'm using this module to generate - at built time - all needed Java source files from Gora schema files.

        Show
        drazzib Damien Raude-Morvan added a comment - Henry Saputra , exactly. @Dictanova we use Gradle extensively for all our modules (in-place of Maven). We don't commit geneated files into Git, so I'm using this module to generate - at built time - all needed Java source files from Gora schema files.
        Hide
        lewismc Lewis John McGibbney added a comment -

        Damien Raude-Morvan I made a comment on the GH issue which I am reflecting here

        Hi @drazzib only thing I would comment is the addition of ASL v2.0 license headers to every file possible. If you can submit that suggestion then I am +1 on this going on. Even in time for the 0.6 release.

        Show
        lewismc Lewis John McGibbney added a comment - Damien Raude-Morvan I made a comment on the GH issue which I am reflecting here Hi @drazzib only thing I would comment is the addition of ASL v2.0 license headers to every file possible. If you can submit that suggestion then I am +1 on this going on. Even in time for the 0.6 release.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user drazzib commented on the pull request:

        https://github.com/apache/gora/pull/19#issuecomment-73860723

        Hi @lewismc

        I've pushed ASL 2.0 headers on some more files but haven't proceed all :

        • gradlew + gradlew.bat + gradle/wrapper/* are auto-generated from Gradle build system
        • examples/simple/src/main/resources/test1.avsc It seems we can't add comment into Gora Schema files ? Am I wrong ?

        I'm okay for pushing this to master now but it should be noted that it's still WiP (for instance, there is no real configuration for source / destination directories)

        Show
        githubbot ASF GitHub Bot added a comment - Github user drazzib commented on the pull request: https://github.com/apache/gora/pull/19#issuecomment-73860723 Hi @lewismc I've pushed ASL 2.0 headers on some more files but haven't proceed all : gradlew + gradlew.bat + gradle/wrapper/* are auto-generated from Gradle build system examples/simple/src/main/resources/test1.avsc It seems we can't add comment into Gora Schema files ? Am I wrong ? I'm okay for pushing this to master now but it should be noted that it's still WiP (for instance, there is no real configuration for source / destination directories)
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lewismc commented on the pull request:

        https://github.com/apache/gora/pull/19#issuecomment-73893685

        Hi @drazzib
        RE: license headers, great
        RE: Gora Schema files, yes you are correct this is absolutely fine
        +1 for commit to master branch. If you are keen and able, please feel free to set up an additional build job on builds.apache.org if you have tests for the plugin which you would like to run.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/19#issuecomment-73893685 Hi @drazzib RE: license headers, great RE: Gora Schema files, yes you are correct this is absolutely fine +1 for commit to master branch. If you are keen and able, please feel free to set up an additional build job on builds.apache.org if you have tests for the plugin which you would like to run.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/gora/pull/19

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/gora/pull/19
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in gora-trunk #1410 (See https://builds.apache.org/job/gora-trunk/1410/)
        GORA-330 Gora Gradle plugin (drazzib) closes apache/gora#19 (drazzib: rev 61a4747ffc1a329bbe60e95517881e963b4a76a8)

        • CHANGES.txt
        • gora-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.apache.gora.properties
        • gora-gradle-plugin/src/main/groovy/org/apache/gora/gradle/GoraCompileTask.groovy
        • gora-gradle-plugin/src/main/groovy/org/apache/gora/gradle/GoraPlugin.groovy
        • gora-gradle-plugin/build.gradle
        • gora-gradle-plugin/gradle/wrapper/gradle-wrapper.jar
        • gora-gradle-plugin/examples/simple/gradle.properties
        • gora-gradle-plugin/examples/simple/src/main/resources/test1.avsc
        • gora-gradle-plugin/gradle.properties
        • gora-gradle-plugin/gradle/wrapper/gradle-wrapper.properties
        • gora-gradle-plugin/README.md
        • gora-gradle-plugin/examples/simple/build.gradle
        • gora-gradle-plugin/gradlew
        • gora-gradle-plugin/src/test/groovy/org/apache/gora/gradle/GoraPluginTest.groovy
        • gora-gradle-plugin/examples/simple/src/main/java/test/Sample.java
        • gora-gradle-plugin/.gitignore
        • gora-gradle-plugin/gradlew.bat
        Show
        hudson Hudson added a comment - FAILURE: Integrated in gora-trunk #1410 (See https://builds.apache.org/job/gora-trunk/1410/ ) GORA-330 Gora Gradle plugin (drazzib) closes apache/gora#19 (drazzib: rev 61a4747ffc1a329bbe60e95517881e963b4a76a8) CHANGES.txt gora-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.apache.gora.properties gora-gradle-plugin/src/main/groovy/org/apache/gora/gradle/GoraCompileTask.groovy gora-gradle-plugin/src/main/groovy/org/apache/gora/gradle/GoraPlugin.groovy gora-gradle-plugin/build.gradle gora-gradle-plugin/gradle/wrapper/gradle-wrapper.jar gora-gradle-plugin/examples/simple/gradle.properties gora-gradle-plugin/examples/simple/src/main/resources/test1.avsc gora-gradle-plugin/gradle.properties gora-gradle-plugin/gradle/wrapper/gradle-wrapper.properties gora-gradle-plugin/README.md gora-gradle-plugin/examples/simple/build.gradle gora-gradle-plugin/gradlew gora-gradle-plugin/src/test/groovy/org/apache/gora/gradle/GoraPluginTest.groovy gora-gradle-plugin/examples/simple/src/main/java/test/Sample.java gora-gradle-plugin/.gitignore gora-gradle-plugin/gradlew.bat

          People

          • Assignee:
            drazzib Damien Raude-Morvan
            Reporter:
            lewismc Lewis John McGibbney
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development