Uploaded image for project: 'Apache Gora'
  1. Apache Gora
  2. GORA-234

Javadoc and java annotations in gora-core base (abstract) classes needs to be corrected

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.3
    • 0.5
    • documentation, gora-core

    Description

      in DataStore#flush() [0] for there is incorrect Java annotations saying that it throws an IOException when it does not. Although this is trivial to address, in my opinion it is really really important that it is corrected.

      [0] http://svn.apache.org/viewvc/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java?view=markup

      Attachments

        1. GORA-234.palsulich.patch
          7 kB
          Tyler Bui-Palsulich

        Activity

          Attached a patch which fixes the improper JavaDoc in DataStore.java and WSDataStoreBase.java. Followup question: Some methods are empty in the abstract base class (e.g. WSDataStoreBase#readFields). Should those methods just be abstract?

          tpalsulich Tyler Bui-Palsulich added a comment - Attached a patch which fixes the improper JavaDoc in DataStore.java and WSDataStoreBase.java. Followup question: Some methods are empty in the abstract base class (e.g. WSDataStoreBase#readFields). Should those methods just be abstract?

          commit da19993d2d92b62b301cad167c71d7617a2944ad
          Author: Lewis John McGibbney <lewis.j.mcgibbney@jpl.nasa.gov>
          Date: Wed Jun 25 14:31:34 2014 -0700

          GORA-234 Javadoc and java annotations in gora-core base (abstract) classes needs to be corrected

          Thank you tpalsulich

          lewismc Lewis John McGibbney added a comment - commit da19993d2d92b62b301cad167c71d7617a2944ad Author: Lewis John McGibbney <lewis.j.mcgibbney@jpl.nasa.gov> Date: Wed Jun 25 14:31:34 2014 -0700 GORA-234 Javadoc and java annotations in gora-core base (abstract) classes needs to be corrected Thank you tpalsulich

          Happy to help!

          tpalsulich Tyler Bui-Palsulich added a comment - Happy to help!
          hudson Hudson added a comment -

          UNSTABLE: Integrated in gora-trunk #1117 (See https://builds.apache.org/job/gora-trunk/1117/)
          GORA-234 Javadoc and java annotations in gora-core base (abstract) classes needs to be corrected (lewis.j.mcgibbney: rev da19993d2d92b62b301cad167c71d7617a2944ad)

          • gora-core/src/main/java/org/apache/gora/store/DataStore.java
          • gora-core/src/main/java/org/apache/gora/store/ws/impl/WSDataStoreBase.java
          • CHANGES.txt
          hudson Hudson added a comment - UNSTABLE: Integrated in gora-trunk #1117 (See https://builds.apache.org/job/gora-trunk/1117/ ) GORA-234 Javadoc and java annotations in gora-core base (abstract) classes needs to be corrected (lewis.j.mcgibbney: rev da19993d2d92b62b301cad167c71d7617a2944ad) gora-core/src/main/java/org/apache/gora/store/DataStore.java gora-core/src/main/java/org/apache/gora/store/ws/impl/WSDataStoreBase.java CHANGES.txt

          People

            tpalsulich Tyler Bui-Palsulich
            lewismc Lewis John McGibbney
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: