[GOBBLIN-61] Making gobblin-admin a module

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: Framework:AdminUI enhancement
• External issue URL: https://github.com/linkedin/gobblin/pull/1540
• Assignee: Unassigned
• Reporter: Abhishek Tiwari
• Created: 19/Jul/17 07:39
• Updated: 07/Aug/17 08:57

Description

• Removed compile dependencies on gobblin-admin – the main challenge was the use of the ADMIN_SERVER_ENABLED_KEY flag rather than dependency injection through config. I had to do the latter but adding a factory interface to gobblin-api and adding ADMIN_SERVER_FACTORY_CLASS_KEY . Eventually, I think the whole implementation has to refactored into a GobblinInstancePlugin that can be specified when the instance is configured.
• Made gobblin-admin as part of the full flavored build

@abti can you review ?

Main changes:

• New interface AdminWebServerFactory
• New default implementation DefaultAdminWebServerFactory which preserves existing functionality
• Adding new dependency injection for the implementation through configs: ConfigurationKeys , ServiceBasedAppLauncher, GobblinYarnAppLauncher,

Github Url : https://github.com/linkedin/gobblin/pull/1540
Github Reporter : chavdar
Github Assignee : abti
Github Created At : 2017-01-13T19:21:48Z
Github Updated At : 2017-04-22T18:41:05Z

Comments

---

chavdar wrote on 2017-01-13T20:18:04Z : + @kadaan for review

Github Url : https://github.com/linkedin/gobblin/pull/1540#issuecomment-272537550

---

chavdar wrote on 2017-01-25T00:11:19Z : Ping.

Github Url : https://github.com/linkedin/gobblin/pull/1540#issuecomment-274980664