Uploaded image for project: 'Apache Gobblin'
  1. Apache Gobblin
  2. GOBBLIN-2019

Remove Circular Dependency & Initialize multi-active execution classes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • gobblin-service
    • None

    Description

      The following PR removes a circular dependency between dagManagementTaskStream & ReminderSettingDagProcLeaseArbiter

      describing the circular dependency: dagManagementTaskStream uses ReminderSettingDagProcLeaseArbiter to obtain lease, if it fails to obtain lease then the ReminderSettingDagProcLeaseArbiter was setting reminder on DagActionReminderScheduler and when reminder fires add the action back to dagManagementTaskStream. To remove circular dependency, I remove the ReminderSettingDagProcLeaseArbiter and use the more generic InstrumentedLeaseArbiter that will only provide the status. Instead,  dagManagementTaskStream will call DagActionReminderScheduler to set reminders and re-add to task stream

      other changes

      • refactor MySqlMultiActiveLeaseArbiter and it's initialization to specify table names through a prefix to differentiate btwn multiple instances 
      • adds jobName to dagActionChangeEvent

      Attachments

        Activity

          People

            abti Abhishek Tiwari
            umustafi Urmi Mustafi
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h