[GOBBLIN-1826] Fix bug in Hive registration code where fields could be miscasted in types

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: gobblin-core
• Assignee: Abhishek Tiwari
• Reporter: William Lo
• Created: 27/Apr/23 02:53
• Updated: 27/Apr/23 18:09

Description

After the Guava 20 upgrade, there was a major bug in the Hive registration code where fields could be casted as an unexpected type in HiveRegistrationUnit 

protected static <T> Optional<T> populateField(State state, String key, TypeToken<T> token) {
 

The field setter is returning an Optional generic, which allows the code to compile but fail during runtime as the types are mismatched, leading to a casting exception when reading the type e.g.

 java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Long at org.apache.gobblin.hive.metastore.HiveMetaStoreUtils.getTable(HiveMetaStoreUtils.java:111)