[GOBBLIN-1384] Fix task cancellation to ensure task commit is invoked only after task completes

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0
• Component/s: gobblin-core
• Assignee: Abhishek Tiwari
• Reporter: Sudarshan Vasudevan
• Created: 09/Feb/21 18:23
• Updated: 14/Jun/23 04:13

Description

Per the current behavior, the task is marked as completed as soon as task cancellation is invoked, which interrupts the task, and immediately decrements a latch counting the number of running tasks. This implies that GobblinMultiTaskAttempt which monitors this countdown latch, can invoke task commit before the task has completed. This can lead to incorrect behavior in batch mode and potential resource leak in the streaming mode where commit failures potentially leaves some resources open.