[GIRAPH-997] Upgrade findbugs to 3.0.0

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: maven
• Assignee: Dionysios Logothetis
• Reporter: Dionysios Logothetis
• Created: 03/Mar/15 18:59
• Updated: 14/Oct/16 00:58
• Resolved: 19/Mar/15 17:43

Description

Finbugs 3.0.0 is necessary to build with Java 8, but it catches the following bugs on mvn -DskipTests -Dcheckstyle.skip=true clean install:

[INFO] — findbugs-maven-plugin:3.0.0:check (default) @ giraph-core —
[INFO] BugInstance size is 8
[INFO] Error size is 0
[INFO] Total bugs: 8
[INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader"] At IntIntTextVertexValueInputFormat.java:[lines 54-71]
[INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader"] At IntNullTextEdgeInputFormat.java:[lines 53-76]
[INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeEdge(String, String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75]
[INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeId(String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75]
[INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220]
[INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerPersistentAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220]
[INFO] org.apache.giraph.zk.ZooKeeperManager.createZooKeeperServerList() invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840]
[INFO] Inconsistent synchronization of org.apache.giraph.zk.ZooKeeperManager.zkRunner; locked 66% of time ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840]