Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-962

TextAggregatorWriter with frequency AT_THE_END writes in every superstep

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: bsp
    • Labels:

      Description

      TextAggregatorWriter is used to write the content of all aggregators in a superstep to a text file. It offers three predefined frequencies:

      NEVER (0)
      ALWAYS (1) // in each superstep
      AT_THE_END (-1) // only in the last superstep

      The aggregators are written in a superstep if the following condition evaluates to true:

      (frequeny == AT_THE_END && superstep == LAST_SUPERSTEP) || (frequency != NEVER && superstep % frequency == 0)

      The problem is, that LAST_SUPERSTEP is represented by -1 and x % -1 = 0 for all x. This leads to the case, that if frequency = AT_THE_END, the content is written in every superstep.

      On way to solve this is to extend the second part of the OR-clause to (frequency != NEVER && frequency != AT_THE_END && superstep % frequency == 0)

        Attachments

        1. GIRAPH-962.patch
          0.7 kB
          Martin Junghanns

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mju Martin Junghanns
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - Not Specified
                Not Specified