Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-872

Minor inconsistencies with netty handler logic after netty 4 upgrade

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: bsp
    • Labels:
      None

      Description

      While debugging some other issues I noticed a few minor inconsistencies and suspected logic bugs in the netty handler changes related to netty 4:

      1.) Classes (RequestServerHandler, ResponseClientHandler) overriding ChannelInboundHandlerAdapter.exceptionCaught() are still calling getCause() on the passed Throwable even though what's being passed in now is the actual cause instead of a wrapper.
      2.) ResponseClientHandler.channelInactive() isn't calling ChannelHandlerContext.fireChannelInactive() like RequestServerHandler does. I believe this is an oversight and not by design.
      3.) ResponseClientHandler.exceptionCaught() is gating the LOG.warn() call with a LOG.isDebugEnabled() check. I suspect this gate should be removed so the warning gets logged properly.

        Attachments

        1. GIRAPH-872.patch
          2 kB
          Craig Muchinsky

          Issue Links

            Activity

              People

              • Assignee:
                cmartella Claudio Martella
                Reporter:
                cmuchinsky@initiatesystems.com Craig Muchinsky
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: