[GIRAPH-839] NettyWorkerAggregatorRequestProcessor tries to reuse request objects

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Pavan Kumar
• Reporter: Pavan Kumar
• Created: 02/Feb/14 17:50
• Updated: 26/Jun/14 19:10
• Resolved: 07/Feb/14 01:48

Description

I was working on upgrading netty to 4.0.14.Final. It is mostly done, after some polishing I will submit a patch for that soon.

While working on the above, I discovered a bug in NettyWorkerAggregatorRequestProcessor. The distributeAggregators method is reusing SendAggregatorsToWorkerRequest objects, which is incorrect since each task has a different task id & (potentially a different) request id. It does not cause any problem with current netty but in the new version I guess due to delayed serialization the object cannot be reused.

Anyway, moving it inside the for loop does not cause any issues with current netty as well.