Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-839

NettyWorkerAggregatorRequestProcessor tries to reuse request objects

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      I was working on upgrading netty to 4.0.14.Final. It is mostly done, after some polishing I will submit a patch for that soon.

      While working on the above, I discovered a bug in NettyWorkerAggregatorRequestProcessor. The distributeAggregators method is reusing SendAggregatorsToWorkerRequest objects, which is incorrect since each task has a different task id & (potentially a different) request id. It does not cause any problem with current netty but in the new version I guess due to delayed serialization the object cannot be reused.

      Anyway, moving it inside the for loop does not cause any issues with current netty as well.

        Attachments

        1. GIRAPH-839.patch
          1 kB
          Pavan Kumar

          Activity

            People

            • Assignee:
              pavanka Pavan Kumar
              Reporter:
              pavanka Pavan Kumar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: