[GIRAPH-739] Discrepancy among numeric constants corresponding to frequency of writing in TextAggregatorWriter

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Labels: aggregator patch writer
• Assignee: Unassigned
• Reporter: Kyle Orlando
• Created: 14/Aug/13 23:43
• Updated: 26/Jun/14 19:10
• Resolved: 15/Aug/13 14:49

Description

In the TextAggreggatorWriter class in org.apache.giraph.aggregators, there are static constants at the top of the class that correspond to the frequency of writing.

The NEVER constant corresponds to never writing anything to a file, and it is assigned an (int) value of 0.

AT_THE_END corresponds to writing to a file only once, when the computation is over, and it is assigned a numeric value of -1.

The third type of frequency is where the discrepancy exists: ALWAYS corresponds to writing to a file in every superstep, and it is also assigned a numeric value of -1.

ALWAYS's value should be changed to a 1. This is because the condition for writing (as governed by the shouldWrite() method) can be met when superstep % frequency == 0, which is always the case when frequency == 1.

Issue Links

• is a clone of: GIRAPH-726 TextAggregatorWriter frequency ALWAYS should be the value 1.