[GIRAPH-678] Disorder of vertex de-serialization and 'initialize' method

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0.0, 1.1.0
• Component/s: graph

Environment

Giraph 1.0, hadoop 0.20.2

• Assignee: Claudio Martella
• Reporter: David Zhang
• Created: 04/Jun/13 05:02
• Updated: 07/Jun/13 13:43

Description

In org.apache.giraph.utils.Writable.readVertexFromDataInput method.
'initialize' method is ahead of vertex de-serialization.

Change the order is ok:

public static <I extends WritableComparable, V extends Writable,
E extends Writable, M extends Writable> Vertex<I, V, E, M>
readVertexFromDataInput(
DataInput input,
ImmutableClassesGiraphConfiguration<I, V, E, M> conf)
throws IOException {
Vertex<I, V, E, M> vertex = conf.createVertex();
I id = conf.createVertexId();
V value = conf.createVertexValue();
OutEdges<I, E> edges = conf.createOutEdges();
id.readFields(input);
value.readFields(input);
edges.readFields(input);
if (input.readBoolean())

{ vertex.voteToHalt(); }

else

{ vertex.wakeUp(); }

vertex.initialize(id, value, edges);
return vertex;
}