Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-263 Precommit test at Jenkns
  3. GIRAPH-316

Add test-patch.sh for precommit test using Jenkins

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: test
    • Labels:
      None

      Description

      For automatic pre-commit tests by jenkins, we need a script for downloading the recent patch, compiling the patched source, and checking warnings. This patch includes the script. I borrowed test-patch.sh from Hadoop, and I modified the following things:

      • Hadoop's test-patch does not allow any javadoc warnings, but this patch allows them and does not allow the increase of javadoc warnings. This is because the current implementation of Giraph already has 47 javadoc warnings.
      • Add the checkstyle check which is not implemented in Hadoop's one.
      • Add an options to take jira user as an argument.
      • Add some codes related to the project directory structure and some messages.
      • Changed some codes to reflect the target directory hierarchy caused by munged.

      You can check the integrated test from https://builds.apache.org/job/PreCommit-GIRAPH-Build/. To execute the test, please click 'Build now' and type the number of Giraph jira issue. Now, I gave the wrong path of the jira cli to jenkins because I don't want to disturb the jira. So, you see "no such file/directory" error in "Adding comment to jira" section)

      After this patch is committed, I'll ask the automatic jenkins hook to builds@a.o as described in http://wiki.apache.org/general/PreCommitBuilds.

        Attachments

        1. GIRAPH-316.patch
          32 kB
          Hyunsik Choi
        2. GIRAPH-316_2.patch
          32 kB
          Hyunsik Choi

          Activity

            People

            • Assignee:
              hyunsik.choi Hyunsik Choi
              Reporter:
              hyunsik.choi Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: