[GIRAPH-240] Our vertices shouldn't accept null ids or values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: graph
• Assignee: Alessandro Presta
• Reporter: Alessandro Presta
• Created: 06/Jul/12 17:40
• Updated: 25/Jul/12 09:05
• Resolved: 25/Jul/12 09:05

Description

I may be missing something, but I don't understand why HashMapVertex and EdgeListVertex (and possibly others) check for null vertexId and vertexValue instead of complaining.

Shouldn't each vertex be forced to have an id and a value? It's a source of potential bugs (see the serialization code that has to check for null and read/write a boolean flag) and I don't see the logic.
If one doesn't want vertex/edge values at all there's always NullWritable.

Issue Links

• Is contained by: GIRAPH-244 Vertex API redesign