[GIRAPH-1069] Race condition in all *ConfOption classes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Assignee: Sergey Edunov
• Reporter: Sergey Edunov
• Created: 08/Jun/16 17:26
• Updated: 14/Oct/16 00:58
• Resolved: 08/Jun/16 22:08

Description

*ConfOption classes, such as ClassConfOption, IntConfOption, FloatConfOption etc, call AllOtions.add(this) from their constructor. This call updates static list without any synchronization. Hence, if you create conf option classes in different threads you run into race condition.

The only reason we have AllOptions is to create documentation. It can be done with reflection instead. So, let's remove AllOtions.add(this) from all conf classes and implement reflection based approach in AllOptions