Uploaded image for project: 'Geronimo'
  1. Geronimo
  2. GERONIMO-640

Remove dependency on Sun internals code for URL decoding

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: 1.0-M3
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      [Looking at 1.0-M3 source code]

      The Geronimo types:
      org.apache.geronimo.system.url.file.Handler
      and
      org.apache.geronimo.system.url.file.FileURLConnection

      both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.

      The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?

        Attachments

        1. decode-patch.txt
          2 kB
          Tim Ellison

          Issue Links

            Activity

              People

              • Assignee:
                dain Dain Sundstrom
                Reporter:
                tellison Tim Ellison
              • Votes:
                1 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: