See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
Is the attached patch for 2.1 or 2.2?
Patch from Gang Yin applied to trunk (2.2-SNAPSHOT) as Rev733885.
Please attach a patch for branches/2.1 if you would like to fix it there also, as the current patch includes properties for portlets that do not exist in 2.1.4-SNAPSHOT....
Agree with Jarek that we don't want identical copies of English properties.... If we only include the *_en.properties, will that solve the issue or do we need both?
My patch is going to rename all *.properties to *_en.properties. Definitely we don't want to keep two copies of the same property file.
I have no idea why all *.properties files are restored, It's weird because I already deleted them. I will attach a new patch to delete them again.
Add a new patch to delete duplicated property file
I'm not sure whether it's correct to only include the *_en.properties. If the browser's locale is set to something that's not in Geronimo's supported locale (en, zh), then there's no language to fall back?
Hi, Jack. I had tested your concern and english will be displayed even if there is no *.properties.
Because the <fmt> tag in jsp pages which is responsible for localization will ignore the property file that has no language suffix, So I renamed all *.properties to *_en.properties.
If the code is using standard ResourceBundles then as described in the JavaDoc we should provide the *.properties files. They are used as the last resort.
This patch can fix the problem discussed above. All *_en.properties files are removed, they are not necessary anymore. All requests with locale of en will load default resource bundle.
I don't quite understand why only the language part of the locale is used ...
Updated patch on the basis of Rev734145
Modified version according to Jack's comment.
Applied locale-priority_fix.patch from Gang Yin to trunk (2.2-SNAPSHOT) as Rev734161.
I ported the patch for 2.1 version.
This patch is the almost same as 2.2 version.
Applied patch from Kan Ogawa to branches/2.1 (2.1.4-SNAPSHOT) as Rev738979.
I give the priority of my language setting to English, but the admin console still displays chinese.
Environment: windows xp professional 2002 sp3 + IE7
It seems that the locale priority problem still exists when using IBM jdk, and this patch can fix the problem when using IBM jdk version 5.
Is this for both 2.1 and 2.2?
I suspect we need unique patches for trunk and branches/2.1. Also, please create patches from the root directory for the appropriate branch. Thank you.
Patch recreated from the root directory, this patch is for geronimo v2.2. Please help me to commit this patch, many thanks.
BTW, geronimo-4550 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.
Applied locale-priority_fix2_v22.patch to trunk in rev 750949. Please verify and provide a patch for branches/2.1.
Thanks Joe, I will provide a patch for 2.1 branch soon.
We need a patch for this in the next day or two or it will not make it into Geronimo 2.1.4.
As Kan Ogawa hadn't finished porting G-4484(back-end message display and localization) and G-4517(front-end message display and localization) to branch 2.1,
so there is no need to provide a patch for branch 2.1.4 at all. Thanks Joe.
To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time?
updated release version as it appears this won't make 2.1.4. Also removed myself as assigned so that others could investigate potential fixes.
This is fixed after adding duplicate message files.