Geronimo
  1. Geronimo
  2. GERONIMO-4507

Admin console should honor the priority of user agent's language setting

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2
    • Fix Version/s: 2.1.5, 2.2
    • Component/s: console
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      All

    1. locale-priority_fix.patch
      200 kB
      Gang Yin
    2. locale-priority_fix2_v22.patch
      95 kB
      Gang Yin
    3. locale-priority_V21.patch
      4 kB
      Kan Ogawa
    4. locale-priority.patch
      197 kB
      Gang Yin

      Activity

      Hide
      Gang Yin added a comment -

      problem solved

      Show
      Gang Yin added a comment - problem solved
      Hide
      Donald Woods added a comment -

      Is the attached patch for 2.1 or 2.2?

      Show
      Donald Woods added a comment - Is the attached patch for 2.1 or 2.2?
      Hide
      Donald Woods added a comment -

      Patch from Gang Yin applied to trunk (2.2-SNAPSHOT) as Rev733885.
      Please attach a patch for branches/2.1 if you would like to fix it there also, as the current patch includes properties for portlets that do not exist in 2.1.4-SNAPSHOT....

      Show
      Donald Woods added a comment - Patch from Gang Yin applied to trunk (2.2-SNAPSHOT) as Rev733885. Please attach a patch for branches/2.1 if you would like to fix it there also, as the current patch includes properties for portlets that do not exist in 2.1.4-SNAPSHOT....
      Hide
      Donald Woods added a comment -

      Agree with Jarek that we don't want identical copies of English properties.... If we only include the *_en.properties, will that solve the issue or do we need both?

      Show
      Donald Woods added a comment - Agree with Jarek that we don't want identical copies of English properties.... If we only include the *_en.properties, will that solve the issue or do we need both?
      Hide
      Gang Yin added a comment -

      My patch is going to rename all *.properties to *_en.properties. Definitely we don't want to keep two copies of the same property file.

      Show
      Gang Yin added a comment - My patch is going to rename all *.properties to *_en.properties. Definitely we don't want to keep two copies of the same property file.
      Hide
      Gang Yin added a comment -

      I have no idea why all *.properties files are restored, It's weird because I already deleted them. I will attach a new patch to delete them again.

      Show
      Gang Yin added a comment - I have no idea why all *.properties files are restored, It's weird because I already deleted them. I will attach a new patch to delete them again.
      Hide
      Gang Yin added a comment -

      Add a new patch to delete duplicated property file

      Show
      Gang Yin added a comment - Add a new patch to delete duplicated property file
      Hide
      Jack Cai added a comment -

      I'm not sure whether it's correct to only include the *_en.properties. If the browser's locale is set to something that's not in Geronimo's supported locale (en, zh), then there's no language to fall back?

      Show
      Jack Cai added a comment - I'm not sure whether it's correct to only include the *_en.properties. If the browser's locale is set to something that's not in Geronimo's supported locale (en, zh), then there's no language to fall back?
      Hide
      Gang Yin added a comment -

      Hi, Jack. I had tested your concern and english will be displayed even if there is no *.properties.
      Because the <fmt> tag in jsp pages which is responsible for localization will ignore the property file that has no language suffix, So I renamed all *.properties to *_en.properties.

      Show
      Gang Yin added a comment - Hi, Jack. I had tested your concern and english will be displayed even if there is no *.properties. Because the <fmt> tag in jsp pages which is responsible for localization will ignore the property file that has no language suffix, So I renamed all *.properties to *_en.properties.
      Hide
      Jarek Gawor added a comment -

      If the code is using standard ResourceBundles then as described in the JavaDoc we should provide the *.properties files. They are used as the last resort.

      Show
      Jarek Gawor added a comment - If the code is using standard ResourceBundles then as described in the JavaDoc we should provide the *.properties files. They are used as the last resort.
      Hide
      Gang Yin added a comment -

      Hi, Donald,
      This patch can fix the problem discussed above. All *_en.properties files are removed, they are not necessary anymore. All requests with locale of en will load default resource bundle.

      Show
      Gang Yin added a comment - Hi, Donald, This patch can fix the problem discussed above. All *_en.properties files are removed, they are not necessary anymore. All requests with locale of en will load default resource bundle.
      Hide
      Jack Cai added a comment -

      I don't quite understand why only the language part of the locale is used ...

      Show
      Jack Cai added a comment - I don't quite understand why only the language part of the locale is used ...
      Hide
      Gang Yin added a comment -

      Updated patch on the basis of Rev734145

      Show
      Gang Yin added a comment - Updated patch on the basis of Rev734145
      Hide
      Gang Yin added a comment -

      Modified version according to Jack's comment.

      Show
      Gang Yin added a comment - Modified version according to Jack's comment.
      Hide
      Donald Woods added a comment -

      Applied locale-priority_fix.patch from Gang Yin to trunk (2.2-SNAPSHOT) as Rev734161.

      Show
      Donald Woods added a comment - Applied locale-priority_fix.patch from Gang Yin to trunk (2.2-SNAPSHOT) as Rev734161.
      Hide
      Kan Ogawa added a comment -

      Donald,

      I ported the patch for 2.1 version.
      This patch is the almost same as 2.2 version.

      Show
      Kan Ogawa added a comment - Donald, I ported the patch for 2.1 version. This patch is the almost same as 2.2 version.
      Hide
      Donald Woods added a comment -

      Applied patch from Kan Ogawa to branches/2.1 (2.1.4-SNAPSHOT) as Rev738979.

      Show
      Donald Woods added a comment - Applied patch from Kan Ogawa to branches/2.1 (2.1.4-SNAPSHOT) as Rev738979.
      Hide
      caiwenjing added a comment -

      I give the priority of my language setting to English, but the admin console still displays chinese.

      Environment: windows xp professional 2002 sp3 + IE7

      Show
      caiwenjing added a comment - I give the priority of my language setting to English, but the admin console still displays chinese. Environment: windows xp professional 2002 sp3 + IE7
      Hide
      Gang Yin added a comment -

      It seems that the locale priority problem still exists when using IBM jdk, and this patch can fix the problem when using IBM jdk version 5.

      Show
      Gang Yin added a comment - It seems that the locale priority problem still exists when using IBM jdk, and this patch can fix the problem when using IBM jdk version 5.
      Hide
      Donald Woods added a comment -

      Is this for both 2.1 and 2.2?

      Show
      Donald Woods added a comment - Is this for both 2.1 and 2.2?
      Hide
      Joe Bohn added a comment -

      I suspect we need unique patches for trunk and branches/2.1. Also, please create patches from the root directory for the appropriate branch. Thank you.

      Show
      Joe Bohn added a comment - I suspect we need unique patches for trunk and branches/2.1. Also, please create patches from the root directory for the appropriate branch. Thank you.
      Hide
      Gang Yin added a comment -

      Patch recreated from the root directory, this patch is for geronimo v2.2. Please help me to commit this patch, many thanks.

      Show
      Gang Yin added a comment - Patch recreated from the root directory, this patch is for geronimo v2.2. Please help me to commit this patch, many thanks.
      Hide
      Gang Yin added a comment - - edited

      BTW, geronimo-4550 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.

      Show
      Gang Yin added a comment - - edited BTW, geronimo-4550 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.
      Hide
      Joe Bohn added a comment -

      Applied locale-priority_fix2_v22.patch to trunk in rev 750949. Please verify and provide a patch for branches/2.1.

      Thanks!

      Show
      Joe Bohn added a comment - Applied locale-priority_fix2_v22.patch to trunk in rev 750949. Please verify and provide a patch for branches/2.1. Thanks!
      Hide
      Gang Yin added a comment -

      Thanks Joe, I will provide a patch for 2.1 branch soon.

      Show
      Gang Yin added a comment - Thanks Joe, I will provide a patch for 2.1 branch soon.
      Hide
      Joe Bohn added a comment -

      We need a patch for this in the next day or two or it will not make it into Geronimo 2.1.4.

      Show
      Joe Bohn added a comment - We need a patch for this in the next day or two or it will not make it into Geronimo 2.1.4.
      Hide
      Gang Yin added a comment -

      As Kan Ogawa hadn't finished porting G-4484(back-end message display and localization) and G-4517(front-end message display and localization) to branch 2.1,
      so there is no need to provide a patch for branch 2.1.4 at all. Thanks Joe.

      Show
      Gang Yin added a comment - As Kan Ogawa hadn't finished porting G-4484(back-end message display and localization) and G-4517(front-end message display and localization) to branch 2.1, so there is no need to provide a patch for branch 2.1.4 at all. Thanks Joe.
      Hide
      Kan Ogawa added a comment -

      Gang,

      To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time?

      Show
      Kan Ogawa added a comment - Gang, To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time?
      Hide
      Joe Bohn added a comment -

      updated release version as it appears this won't make 2.1.4. Also removed myself as assigned so that others could investigate potential fixes.

      Show
      Joe Bohn added a comment - updated release version as it appears this won't make 2.1.4. Also removed myself as assigned so that others could investigate potential fixes.
      Hide
      Ivan added a comment -

      This is fixed after adding duplicate message files.

      Show
      Ivan added a comment - This is fixed after adding duplicate message files.
      Hide
      Rex Wang added a comment -

      closing it.

      Show
      Rex Wang added a comment - closing it.

        People

        • Assignee:
          Unassigned
          Reporter:
          Jack Cai
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development