Geronimo
  1. Geronimo
  2. GERONIMO-4475

Improve JMS portlet for AMQ 5.3 Broker configuration

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: console
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Currently in the administrator console, the users could not add another embed broker. Also, they could not edit the broker through administrator console.
      I list the features that I could see :
      1. While creating the broker, let the use upload a configuration file.
      2. While editing the broker, show a text area, so that the user could edit the spring XML file in it. Shall we give the user a more friendly interface, so that they do not need the edit the XML file directly. I am not sure how it should look like.
      3. Update the connector port let, so that while creating a new connector, the user could specify the broker that it belongs to.
      Please help to give some comments !

        Activity

        Hide
        Ivan added a comment -

        After updating the local source files from svn, just find the ActiveMQ version for 2.2 snapshot is changed to 5.3-snapshot.
        So I wonder which version we will include in 2.2, for I am working on the JMS portlet, I need to the right version to work with.
        Thanks for giving a comment !

        Show
        Ivan added a comment - After updating the local source files from svn, just find the ActiveMQ version for 2.2 snapshot is changed to 5.3-snapshot. So I wonder which version we will include in 2.2, for I am working on the JMS portlet, I need to the right version to work with. Thanks for giving a comment !
        Hide
        Donald Woods added a comment -

        Use 5.3-SNAPSHOT for now, as we rant into TCK failures with AMQ 5.2.....

        Show
        Donald Woods added a comment - Use 5.3-SNAPSHOT for now, as we rant into TCK failures with AMQ 5.2.....
        Hide
        Ivan added a comment -

        I divided the patch for three parts, for we could see clearly which parts are changed.

        activemq-portlet
        a. jsp files ( broker editing in the "server" folder and jms resource in the "jmswizard" folder )
        b. java files ( broker editing and jms resource to support multiple brokers )
        c. resource property files

        geronimo-management
        a. add two methods to the jmsmanager interface ( addbroker and removebroker )

        activemq-broker
        a. add a activemq-template file
        b. change the activemq.xml file, use system property placeholder $

        {activemq.brokerName}

        c. do some modification about the plan.xml
        d. change the pom file to copy the template file to the conf/template folder

        geronimo-activemq
        a. add a new attribute ( broker name ) for the Broker GBean

        Currently, the patch provide a simple way to add the broker. When the user clicks the add broker link, a big edit box will show on the page, and a template configuraiton file will be loaded. So that the user can directly edit the configuration in that edit box. When the save button is clicked, some actions will be done :
        a. save the xml file to /var/activemq/conf/$

        {brokerName}.xml
        b. set the data folder to /var/activemq/data/${brokerName}

        c. A broker gbean is added to the activemq-broker configuration

        For the user could configure the connectors in the broker configuration file, so I removed the add connector links (actually, no implementations for it exist in the current source repository).

        Please help to giving any comment , thanks !

        Show
        Ivan added a comment - I divided the patch for three parts, for we could see clearly which parts are changed. activemq-portlet a. jsp files ( broker editing in the "server" folder and jms resource in the "jmswizard" folder ) b. java files ( broker editing and jms resource to support multiple brokers ) c. resource property files geronimo-management a. add two methods to the jmsmanager interface ( addbroker and removebroker ) activemq-broker a. add a activemq-template file b. change the activemq.xml file, use system property placeholder $ {activemq.brokerName} c. do some modification about the plan.xml d. change the pom file to copy the template file to the conf/template folder geronimo-activemq a. add a new attribute ( broker name ) for the Broker GBean Currently, the patch provide a simple way to add the broker. When the user clicks the add broker link, a big edit box will show on the page, and a template configuraiton file will be loaded. So that the user can directly edit the configuration in that edit box. When the save button is clicked, some actions will be done : a. save the xml file to /var/activemq/conf/$ {brokerName}.xml b. set the data folder to /var/activemq/data/${brokerName} c. A broker gbean is added to the activemq-broker configuration For the user could configure the connectors in the broker configuration file, so I removed the add connector links (actually, no implementations for it exist in the current source repository). Please help to giving any comment , thanks !
        Hide
        Ivan added a comment -

        I will update the portlet according to the G-4484, so remove the old patch.

        Show
        Ivan added a comment - I will update the portlet according to the G-4484, so remove the old patch.
        Hide
        Ivan added a comment -

        Do some slight changes about the error messages.

        Show
        Ivan added a comment - Do some slight changes about the error messages.
        Hide
        Ivan added a comment -

        Sorry, I lost some items in the resource property files.
        An update one, thanks !

        Show
        Ivan added a comment - Sorry, I lost some items in the resource property files. An update one, thanks !
        Hide
        Ivan added a comment -

        Update the codes according to the changes of G-4484. Thanks !

        Show
        Ivan added a comment - Update the codes according to the changes of G-4484. Thanks !
        Hide
        Ivan added a comment -

        Update patch to support PortOffset in the activemq configuration xml file, a customized spring placeholder is added.
        For discussion, please refer to http://www.nabble.com/Dual-ActiveMQ-configuration-style--WAS:-Add-tomcat-specific-configuration--tt21453929.html
        Thanks !

        Show
        Ivan added a comment - Update patch to support PortOffset in the activemq configuration xml file, a customized spring placeholder is added. For discussion, please refer to http://www.nabble.com/Dual-ActiveMQ-configuration-style--WAS:-Add-tomcat-specific-configuration--tt21453929.html Thanks !
        Hide
        Donald Woods added a comment -

        Applied the 4 patches to trunk (2.2-SNAPSHOT) as Rev736391. Ivan, thanks for the patches.
        Also, can we look at adding some portlet help or links to the 2.2 Docs on how to update the activemq.xml content and some simple examples? The usage of $

        {activemq.*}

        has made it even harder to understand what to change or how config-substitutions.properties will be used.

        Show
        Donald Woods added a comment - Applied the 4 patches to trunk (2.2-SNAPSHOT) as Rev736391. Ivan, thanks for the patches. Also, can we look at adding some portlet help or links to the 2.2 Docs on how to update the activemq.xml content and some simple examples? The usage of $ {activemq.*} has made it even harder to understand what to change or how config-substitutions.properties will be used.
        Hide
        Donald Woods added a comment -

        updating title to include ref to AMQ 5.3

        Show
        Donald Woods added a comment - updating title to include ref to AMQ 5.3
        Hide
        Ivan added a comment -

        Thanks, Donald, I will prepare a doc for the JMS portlet soon.

        Show
        Ivan added a comment - Thanks, Donald, I will prepare a doc for the JMS portlet soon.
        Hide
        Ying Tang added a comment -

        Thanks Ivan. The document has been posted on this page:

        http://cwiki.apache.org/confluence/display/GMOxDOC22/Configuring+the+JMS+server

        Any comments?

        Show
        Ying Tang added a comment - Thanks Ivan. The document has been posted on this page: http://cwiki.apache.org/confluence/display/GMOxDOC22/Configuring+the+JMS+server Any comments?
        Hide
        Ivan added a comment -

        A slight modification about the activemq.xml file, specify a location for temp folder for the broker.
        Please help to review it !

        Show
        Ivan added a comment - A slight modification about the activemq.xml file, specify a location for temp folder for the broker. Please help to review it !
        Hide
        Donald Woods added a comment -

        OK, testing out the patch now.

        Show
        Donald Woods added a comment - OK, testing out the patch now.
        Hide
        Donald Woods added a comment -

        Another minor update from Ivan to apply.

        Show
        Donald Woods added a comment - Another minor update from Ivan to apply.
        Hide
        Donald Woods added a comment -

        Ivan, did you run a full build including the testsuite with this patch?
        I'm getting the following testsuite failure with the patch applied -

        -------------------------------------------------------------------------------
        Test set: TestSuite
        -------------------------------------------------------------------------------
        Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.908 sec <<< FAILURE!
        sendRequests(org.apache.geronimo.testsuite.enterprise.jms.MessageSenderTest)  Time elapsed: 1.053 sec  <<< FAILURE!
        java.lang.Exception: did not receive message: 3
                at org.apache.geronimo.testsuite.enterprise.jms.MessageSenderTest.sendRequests(MessageSenderTest.java:74)
        
        Show
        Donald Woods added a comment - Ivan, did you run a full build including the testsuite with this patch? I'm getting the following testsuite failure with the patch applied - ------------------------------------------------------------------------------- Test set: TestSuite ------------------------------------------------------------------------------- Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.908 sec <<< FAILURE! sendRequests(org.apache.geronimo.testsuite.enterprise.jms.MessageSenderTest) Time elapsed: 1.053 sec <<< FAILURE! java.lang.Exception: did not receive message: 3 at org.apache.geronimo.testsuite.enterprise.jms.MessageSenderTest.sendRequests(MessageSenderTest.java:74)
        Hide
        Ivan added a comment -

        Donald, that case passed on my windows machine, I used the 20090202 snapshot with the patch applied.
        Basically, I just set the temp path for the broker in the patch.
        Thanks !

        Show
        Ivan added a comment - Donald, that case passed on my windows machine, I used the 20090202 snapshot with the patch applied. Basically, I just set the temp path for the broker in the patch. Thanks !
        Hide
        John Sisson added a comment -

        Corrected description

        Show
        John Sisson added a comment - Corrected description
        Hide
        Ivan added a comment -

        I run the testcases failed in the comment of Donald, it passes.
        Commit changes to trunk revision: 754635
        Update the temp storage path and the binding host name with the values in the config-substitution.properties.

        Show
        Ivan added a comment - I run the testcases failed in the comment of Donald, it passes. Commit changes to trunk revision: 754635 Update the temp storage path and the binding host name with the values in the config-substitution.properties.
        Hide
        Forrest Xia added a comment -

        A bug found:
        if stopped a new created broker, the JMS resources page will show nothing, even the default broker is still running!
        Moreover, the jms connector module which depends on the new created broker is still in running state. But we should expect it in stopped state.

        Show
        Forrest Xia added a comment - A bug found: if stopped a new created broker, the JMS resources page will show nothing, even the default broker is still running! Moreover, the jms connector module which depends on the new created broker is still in running state. But we should expect it in stopped state.

          People

          • Assignee:
            Ivan
            Reporter:
            Ivan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development