Geronimo
  1. Geronimo
  2. GERONIMO-4228

install plugin from deploy tool doesn't honor load="false"

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.1.2, 2.1.3, 2.2
    • Fix Version/s: 2.1.3, 2.2
    • Component/s: Plugins
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:

      <config-xml-content load="false"/>

      This is an issue for app client, which we dont want to start in the server container.

        Activity

        Lin Sun made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Lin Sun made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Lin Sun added a comment -

        Patch committed (see subversion tab). Thanks Donald for reviewing it.

        Tested this with daytrader-tomcat, daytrader-ws-client and daytrader-streamer-client module.

        Lin

        Show
        Lin Sun added a comment - Patch committed (see subversion tab). Thanks Donald for reviewing it. Tested this with daytrader-tomcat, daytrader-ws-client and daytrader-streamer-client module. Lin
        Donald Woods made changes -
        Patch Info [Patch Available]
        Donald Woods made changes -
        Fix Version/s 2.1.3 [ 12313316 ]
        Hide
        Donald Woods added a comment -

        Looks okay to me.
        Fix also needs to go into the 2.1 branch.

        Show
        Donald Woods added a comment - Looks okay to me. Fix also needs to go into the 2.1 branch.
        Lin Sun made changes -
        Attachment G4228.patch [ 12387683 ]
        Hide
        Lin Sun added a comment -

        A proposed patch for this.

        Show
        Lin Sun added a comment - A proposed patch for this.
        Lin Sun made changes -
        Field Original Value New Value
        Summary plugininstaller doesn't honor load="false" install plugin from deploy tool doesn't honor load="false"
        Description When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) plugininstaller ignores it and still attempt to start the module:

        <config-xml-content load="false"/>

        This is an issue for app client, which we dont want to start in the server container.

        When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:

        <config-xml-content load="false"/>

        This is an issue for app client, which we dont want to start in the server container.

        Hide
        Lin Sun added a comment -

        It turned out that this is an issue with plugin installed from command deploy tool (deploy.bat or deploy.sh). Installing plugin from admin console works fine.

        The command deploy tool had some code to start the module after everything is downloaded. This isn't needed as it is already taken care of by the PluginInstallerGBean, which loads the config-xml-content and starts everything that should have been loaded per the persistentConfigurationLists.

        Show
        Lin Sun added a comment - It turned out that this is an issue with plugin installed from command deploy tool (deploy.bat or deploy.sh). Installing plugin from admin console works fine. The command deploy tool had some code to start the module after everything is downloaded. This isn't needed as it is already taken care of by the PluginInstallerGBean, which loads the config-xml-content and starts everything that should have been loaded per the persistentConfigurationLists.
        Lin Sun created issue -

          People

          • Assignee:
            Lin Sun
            Reporter:
            Lin Sun
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development