Geronimo
  1. Geronimo
  2. GERONIMO-4099

Calling isUserInRole wipes out run-as info

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.x, 2.1.x, 2.2
    • Fix Version/s: 2.1.2, 2.2
    • Component/s: Tomcat
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      TomcatGeronimoRealm.hasRole sets callers which it has no business doing. These were already set during authentication. This wipes out the run-as info which was set earlier. Checking the principal is also unrelated to role checks in geronimo and should be omitted.

        Activity

        Hide
        David Jencks added a comment -

        fixed trunk rev 663423. We should check this doesn't break any tck stuff

        Show
        David Jencks added a comment - fixed trunk rev 663423. We should check this doesn't break any tck stuff
        Hide
        David Jencks added a comment -

        branches 2.1 rev 663477
        branches 2.0 rev 663484

        Leaving open until we check tck results.

        Show
        David Jencks added a comment - branches 2.1 rev 663477 branches 2.0 rev 663484 Leaving open until we check tck results.
        Hide
        Joe Bohn added a comment -

        Changed fix version from 2.1.x to 2.1.2 per Jarek's update indicating this was required for 2.1.2.

        Show
        Joe Bohn added a comment - Changed fix version from 2.1.x to 2.1.2 per Jarek's update indicating this was required for 2.1.2.
        Hide
        Joe Bohn added a comment -

        I verified tck results with rev. 674565 and didn't notice any problems. Can we close this issue?

        Show
        Joe Bohn added a comment - I verified tck results with rev. 674565 and didn't notice any problems. Can we close this issue?
        Hide
        David Jencks added a comment -

        apparently causes no tck problems.

        Show
        David Jencks added a comment - apparently causes no tck problems.

          People

          • Assignee:
            David Jencks
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development