Geronimo
  1. Geronimo
  2. GERONIMO-4081

Accessibility issue: Webking scan errors against "Check Web Accessibility(Section 508)" rules

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.1.2, 2.2
    • Fix Version/s: 2.2
    • Component/s: console
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Windows XP SP2, IE 6.0
      Webking 5.5

      Description

      Lots of instances are violated from the accessibility rules of section 508, see the attachment for details. thanks!

      1. webking_scan_results.csv
        1.50 MB
        Forrest Xia
      2. webking_scan_results_src.csv
        403 kB
        Jack Cai
      3. screenshot-1.jpg
        156 kB
        Rex Wang
      4. scan results-WCAG 2.0.csv
        11 kB
        Shiny Cheng
      5. Plancreator-4081.patch
        8 kB
        Ivan
      6. GERONIMO-4081-welcome.patch
        0.7 kB
        Ivan
      7. GERONIMO-4081-system-database.patch
        30 kB
        Ivan
      8. GERONIMO-4081-plancreator.patch
        31 kB
        Ivan
      9. GERONIMO-4081-monitoring.patch
        145 kB
        Ivan
      10. GERONIMO-4081-debugviews.patch
        13 kB
        Ivan
      11. GERONIMO-4081-console.patch
        131 kB
        Ivan
      12. GERONIMO-4081-ca-helper.patch
        7 kB
        Ivan
      13. GERONIMO-4081-activemq.patch
        28 kB
        Ivan

        Activity

        Hide
        Jack Cai added a comment -

        The above result has many duplications because the scan was done against the source code with built targets.

        The new attachment "webking_scan_results_src.csv" is the result of scanning the "pure" source code.

        Show
        Jack Cai added a comment - The above result has many duplications because the scan was done against the source code with built targets. The new attachment "webking_scan_results_src.csv" is the result of scanning the "pure" source code.
        Hide
        Rex Wang added a comment -

        please see the errs in red line, the problems are from the files in "repository\org\dojotoolkit\dojo-ajax\0.4.3\dojo-ajax-0.4.3.zip", whether or not should we modify the files in repository?

        Show
        Rex Wang added a comment - please see the errs in red line, the problems are from the files in "repository\org\dojotoolkit\dojo-ajax\0.4.3\dojo-ajax-0.4.3.zip", whether or not should we modify the files in repository?
        Hide
        Ivan added a comment -

        This patch is for /plugins/welcome, an alt attribute is added for an image tag.

        Show
        Ivan added a comment - This patch is for /plugins/welcome, an alt attribute is added for an image tag.
        Hide
        Donald Woods added a comment -

        Patch for Welcome app applied to trunk and branches/2.1. Thanks.

        Show
        Donald Woods added a comment - Patch for Welcome app applied to trunk and branches/2.1. Thanks.
        Hide
        Ivan added a comment -

        Fix accessibility issues in the /plugins/activemq folder
        1. Add label tag for those form components

        Show
        Ivan added a comment - Fix accessibility issues in the /plugins/activemq folder 1. Add label tag for those form components
        Hide
        Ivan added a comment -

        Fix accessibility issue in the plugins\ca-helper folder
        a. Add label fro those form components

        Show
        Ivan added a comment - Fix accessibility issue in the plugins\ca-helper folder a. Add label fro those form components
        Hide
        Ivan added a comment -

        Fix accessibility issues about lacking label for those input box
        The patch is for /plugins/console folder

        Show
        Ivan added a comment - Fix accessibility issues about lacking label for those input box The patch is for /plugins/console folder
        Hide
        Donald Woods added a comment -

        Applied GERONIMO-4081-console.patch to trunk as Rev675083.
        Applied GERONIMO-4081-ca-helper.patch to trunk as Rev675084.
        Applied GERONIMO-4081-activemq.patch to trunk as Rev675085.

        Show
        Donald Woods added a comment - Applied GERONIMO-4081 -console.patch to trunk as Rev675083. Applied GERONIMO-4081 -ca-helper.patch to trunk as Rev675084. Applied GERONIMO-4081 -activemq.patch to trunk as Rev675085.
        Hide
        Ivan added a comment -

        Fix for accessibility issue .\plugins\debugviews

        Show
        Ivan added a comment - Fix for accessibility issue .\plugins\debugviews
        Hide
        Ivan added a comment -

        Fix for accessibility issue .\plugins\monitoring

        Show
        Ivan added a comment - Fix for accessibility issue .\plugins\monitoring
        Hide
        Ivan added a comment -

        Fix for accessibility issue .\plugins\plancreator

        Show
        Ivan added a comment - Fix for accessibility issue .\plugins\plancreator
        Hide
        Ivan added a comment -

        Fix for accessibility issue .\plugins\system-database

        Show
        Ivan added a comment - Fix for accessibility issue .\plugins\system-database
        Hide
        Donald Woods added a comment -

        Applied GERONIMO-4081-debugviews.patch against trunk as Rev696119

        Show
        Donald Woods added a comment - Applied GERONIMO-4081 -debugviews.patch against trunk as Rev696119
        Hide
        Donald Woods added a comment -

        Applied GERONIMO-4081-monitoring.patch to trunk as Rev696124

        Show
        Donald Woods added a comment - Applied GERONIMO-4081 -monitoring.patch to trunk as Rev696124
        Hide
        Donald Woods added a comment -

        Applied GERONIMO-4081-plancreator.patch to trunk as Rev696126.
        There was one change to plancreator-portlets/src/main/webapp/WEB-INF/view/configcreator/enterpriseApp.jsp at line 335 that could not be applied to changes in the source.

        Show
        Donald Woods added a comment - Applied GERONIMO-4081 -plancreator.patch to trunk as Rev696126. There was one change to plancreator-portlets/src/main/webapp/WEB-INF/view/configcreator/enterpriseApp.jsp at line 335 that could not be applied to changes in the source.
        Hide
        Donald Woods added a comment -

        Applied GERONIMO-4081-system-database.patch to trunk as Rev696131

        Show
        Donald Woods added a comment - Applied GERONIMO-4081 -system-database.patch to trunk as Rev696131
        Hide
        Ivan added a comment -

        After applying this one, I think currently there is no similiar accessibility issue in the admin console. _
        But maybe we need to pay attention to it in the future , anyway it is very simple to avoid this issue !

        Show
        Ivan added a comment - After applying this one, I think currently there is no similiar accessibility issue in the admin console. _ But maybe we need to pay attention to it in the future , anyway it is very simple to avoid this issue !
        Hide
        Donald Woods added a comment -

        Applied Plancreator-4081.patch to trunk as Rev700197

        Show
        Donald Woods added a comment - Applied Plancreator-4081.patch to trunk as Rev700197
        Hide
        Donald Woods added a comment -

        Last expected patch has been applied.
        Ivan, if additional problems are found before 2.2 is released, please open new JIRAs and assign to me.
        Also, can you add a page to the Dev wiki (GMOxDEV) about the Webking tests and how to avoid these problems in the future?

        Show
        Donald Woods added a comment - Last expected patch has been applied. Ivan, if additional problems are found before 2.2 is released, please open new JIRAs and assign to me. Also, can you add a page to the Dev wiki (GMOxDEV) about the Webking tests and how to avoid these problems in the future?
        Hide
        Shiny Cheng added a comment - - edited

        I scanned on trunk (rev 793772) and no V and SV agaisnt "Check Web Accessibility(Section 508)" rules were found.

        However, there exist some violation against "Check Web Accessibility(WCAG 2.0)" rules. Could anybody take a look at this? Thanks.

        Show
        Shiny Cheng added a comment - - edited I scanned on trunk (rev 793772) and no V and SV agaisnt "Check Web Accessibility(Section 508)" rules were found. However, there exist some violation against "Check Web Accessibility(WCAG 2.0)" rules. Could anybody take a look at this? Thanks.
        Hide
        Kevan Miller added a comment -

        Please open a new Jira for this.

        Show
        Kevan Miller added a comment - Please open a new Jira for this.
        Hide
        Shiny Cheng added a comment -

        I have opend a new JIRA.

        Show
        Shiny Cheng added a comment - I have opend a new JIRA.

          People

          • Assignee:
            Ivan
            Reporter:
            Forrest Xia
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development