Geronimo
  1. Geronimo
  2. GERONIMO-3830

GeronimoPropertiesFileMappedPasswordCredentialLoginModuleTest assumes a specific Set ordering

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3, 2.1, 2.2
    • Component/s: security
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Java 1.6
      Fedora 8

    • Patch Info:
      Patch Available
    • Regression:
      Unit Test Broken

      Description

      GeronimoPropertiesFileMappedPasswordCredentialLoginModuleTest fails with Java 1.6 because it assumes that an Iterator over a Set will have a specific ordering. Evidently Java 1.6's HashSet is different enough than 1.5's that it orders its contents differently.

        Activity

        Hide
        toby cabot added a comment -

        Patch to use a TreeSet so the Iterator can be counted on to iterate over the contents in a specific order.

        Show
        toby cabot added a comment - Patch to use a TreeSet so the Iterator can be counted on to iterate over the contents in a specific order.
        Hide
        Donald Woods added a comment -

        Committed to branches/2.0 with Rev619750.

        Show
        Donald Woods added a comment - Committed to branches/2.0 with Rev619750.
        Hide
        Donald Woods added a comment -

        Committed to trunk with Rev619754

        Show
        Donald Woods added a comment - Committed to trunk with Rev619754
        Hide
        Donald Woods added a comment -

        Committed to branches/2.1 as Rev619757.
        Toby, thanks for the patch.

        Show
        Donald Woods added a comment - Committed to branches/2.1 as Rev619757. Toby, thanks for the patch.

          People

          • Assignee:
            Donald Woods
            Reporter:
            toby cabot
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development