Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.1.1, 2.2
    • Fix Version/s: 2.0.3, 2.1.1, 2.2
    • Component/s: core
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Apache Harmony

      Description

      There's a flaw in org.apache.geronimo.system.configuration.GBeanOverride:

      getValue(), lines 388-389:
      PropertyEditor editor = loadPropertyEditor(attribute, classLoader);
      editor.setAsText(value);

      loadPropertyEditor() may return null (lines 402, 407) and this can cause NPE.

      I didn't see this NPE on Sun, but it occurs on Harmony (clearly some other issue exists causing the loadPropertyEditor() to return null, investigating) and I think it's a problem anyway.

        Issue Links

          Activity

          Vasily Zakharov created issue -
          Vasily Zakharov made changes -
          Field Original Value New Value
          Link This issue relates to HARMONY-5477 [ HARMONY-5477 ]
          Hide
          Vasily Zakharov added a comment -

          The root cause for the NPE observed on Harmony is HARMONY-5477.

          However, the mentioned code flaw still exists.

          Show
          Vasily Zakharov added a comment - The root cause for the NPE observed on Harmony is HARMONY-5477 . However, the mentioned code flaw still exists.
          Vasily Zakharov made changes -
          Affects Version/s 2.1.1 [ 12312941 ]
          Affects Version/s 2.2 [ 12312965 ]
          Donald Woods made changes -
          Assignee Donald Woods [ drwoods ]
          Donald Woods made changes -
          Component/s core [ 10391 ]
          Fix Version/s 2.2 [ 12312965 ]
          Fix Version/s 2.1.1 [ 12312941 ]
          Jarek Gawor made changes -
          Assignee Donald Woods [ drwoods ] Jarek Gawor [ gawor@mcs.anl.gov ]
          Jarek Gawor made changes -
          Affects Version/s 2.0.2 [ 12312731 ]
          Hide
          Jarek Gawor added a comment -

          Changed the code so that IllegalStateException is raised when the PropertyEditor cannot be loaded or found. Committed changes to trunk (revision 637260) and branches/2.1 (revision 637261).

          Show
          Jarek Gawor added a comment - Changed the code so that IllegalStateException is raised when the PropertyEditor cannot be loaded or found. Committed changes to trunk (revision 637260) and branches/2.1 (revision 637261).
          Jarek Gawor made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Donald Woods added a comment -

          Merged in relevant changes from branches/2.1 into branches/2.0 with revision 643444

          Show
          Donald Woods added a comment - Merged in relevant changes from branches/2.1 into branches/2.0 with revision 643444
          Donald Woods made changes -
          Fix Version/s 2.0.x [ 12312601 ]
          Joe Bohn made changes -
          Fix Version/s 2.0.x [ 12312601 ]
          Fix Version/s 2.0.3 [ 12313315 ]
          Hide
          Vasily Zakharov added a comment -

          Closed.

          Show
          Vasily Zakharov added a comment - Closed.
          Vasily Zakharov made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          38d 2h 39m 1 Jarek Gawor 14/Mar/08 20:59
          Resolved Resolved Closed Closed
          760d 2h 37m 1 Vasily Zakharov 13/Apr/10 23:37

            People

            • Assignee:
              Jarek Gawor
              Reporter:
              Vasily Zakharov
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development