Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.1.1, 2.2
    • Fix Version/s: 2.0.3, 2.1.1, 2.2
    • Component/s: core
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Apache Harmony

      Description

      There's a flaw in org.apache.geronimo.system.configuration.GBeanOverride:

      getValue(), lines 388-389:
      PropertyEditor editor = loadPropertyEditor(attribute, classLoader);
      editor.setAsText(value);

      loadPropertyEditor() may return null (lines 402, 407) and this can cause NPE.

      I didn't see this NPE on Sun, but it occurs on Harmony (clearly some other issue exists causing the loadPropertyEditor() to return null, investigating) and I think it's a problem anyway.

        Issue Links

          Activity

          Hide
          Vasily Zakharov added a comment -

          The root cause for the NPE observed on Harmony is HARMONY-5477.

          However, the mentioned code flaw still exists.

          Show
          Vasily Zakharov added a comment - The root cause for the NPE observed on Harmony is HARMONY-5477 . However, the mentioned code flaw still exists.
          Hide
          Jarek Gawor added a comment -

          Changed the code so that IllegalStateException is raised when the PropertyEditor cannot be loaded or found. Committed changes to trunk (revision 637260) and branches/2.1 (revision 637261).

          Show
          Jarek Gawor added a comment - Changed the code so that IllegalStateException is raised when the PropertyEditor cannot be loaded or found. Committed changes to trunk (revision 637260) and branches/2.1 (revision 637261).
          Hide
          Donald Woods added a comment -

          Merged in relevant changes from branches/2.1 into branches/2.0 with revision 643444

          Show
          Donald Woods added a comment - Merged in relevant changes from branches/2.1 into branches/2.0 with revision 643444
          Hide
          Vasily Zakharov added a comment -

          Closed.

          Show
          Vasily Zakharov added a comment - Closed.

            People

            • Assignee:
              Jarek Gawor
              Reporter:
              Vasily Zakharov
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development