Geronimo
  1. Geronimo
  2. GERONIMO-3782

tld files may not be getting their schema upgraded correctly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1, 2.0.2
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: deployment
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out

      <?xml version="1.0" encoding="ISO-8859-1" ?>
      <!DOCTYPE taglib
      PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
      "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
      <taglib>
      <tlib-version>1.0</tlib-version>
      <jsp-version>1.2</jsp-version>
      <short-name>scriptfree</short-name>
      <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>

      has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:

      <init-param>
      <param-name>allowDeclarations</param-name>
      <param-value>false</param-value>
      <description>Controls whether or not declarations are considered
      valid.</description>
      </init-param>

      We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

        Activity

        Hide
        David Jencks added a comment -

        dtd contains
        <!ELEMENT init-param (param-name, param-value, description?)>
        so this is consistent with the dtd and the upgrade is not working properly

        Show
        David Jencks added a comment - dtd contains <!ELEMENT init-param (param-name, param-value, description?)> so this is consistent with the dtd and the upgrade is not working properly
        Hide
        Jarek Gawor added a comment -

        Yes, there was a problem with dtd->xsd translation. Sometimes some elements were skipped during the translation (if there were the last child in a list).
        I committed fixes and tests to trunk (revision 615271, 615290) and branches/2.0 (revision 615305).

        Show
        Jarek Gawor added a comment - Yes, there was a problem with dtd->xsd translation. Sometimes some elements were skipped during the translation (if there were the last child in a list). I committed fixes and tests to trunk (revision 615271, 615290) and branches/2.0 (revision 615305).

          People

          • Assignee:
            Jarek Gawor
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development