Geronimo
  1. Geronimo
  2. GERONIMO-3620

Remote deployment using command line deployer does not really work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: deployment
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Remote deployment using command line deployer tool does not really work currently as the host has to be localhost. Here are my observations.
      1. Deployer.getRemoteDeployUploadURL() is not checking if the contextPath starts with a '/' thus resulting in an incorrect URL like http://localhost:8080//remote-deploy/upload.
      2. Using a remoteDeployAddress like http://localhost:8080 with hostname localhost is not useful at all. When the host we are deploying to is the local machine itself, RemoteDeploymentManager.isSameMachine() returns true and in this case the local files are used directly.

        Issue Links

          Activity

          Hide
          Gianny Damour added a comment -

          Hi Vamsi. I fixed 1. a couple of days ago.

          Show
          Gianny Damour added a comment - Hi Vamsi. I fixed 1. a couple of days ago.
          Hide
          Vamsavardhana Reddy added a comment -

          Completed: At revision: 597012
          o Apparently rev 596561 handles the '/' in contextPath issue.
          o Merging rev 596561 from trunk.
          This fix will still bomb if the contextPath is "/" or base url ends with "/"

          Show
          Vamsavardhana Reddy added a comment - Completed: At revision: 597012 o Apparently rev 596561 handles the '/' in contextPath issue. o Merging rev 596561 from trunk. This fix will still bomb if the contextPath is "/" or base url ends with "/"
          Hide
          Vamsavardhana Reddy added a comment -

          Gianny,

          I am crippled at building trunk coz my laptop will crash while building geronimo-system module. So, I have not built trunk recently. Shiva hinted about your fix, after which I looked up the revision and merged it into branches\2.0. The fix will still need to handle contextPath "/" as well as remoteDeployAddress ending in "/".

          ++Vamsi

          Show
          Vamsavardhana Reddy added a comment - Gianny, I am crippled at building trunk coz my laptop will crash while building geronimo-system module. So, I have not built trunk recently. Shiva hinted about your fix, after which I looked up the revision and merged it into branches\2.0. The fix will still need to handle contextPath "/" as well as remoteDeployAddress ending in "/". ++Vamsi
          Hide
          YunFeng Ma added a comment -

          I just submitted a patch for GERONIMO-3583 and that patch can handle the double "//" in Deployer.getRemoteDeployUploadURL(). Thanks.

          Show
          YunFeng Ma added a comment - I just submitted a patch for GERONIMO-3583 and that patch can handle the double "//" in Deployer.getRemoteDeployUploadURL(). Thanks.
          Hide
          Vamsavardhana Reddy added a comment -

          Completed: At revision: 597042 http://svn.apache.org/viewvc?rev=597042&view=rev
          o Normalize the URL to remove extra slashes.
          o Thanks to YunFeng Ma for pointing to the patch under GERONIMO-3583.

          Show
          Vamsavardhana Reddy added a comment - Completed: At revision: 597042 http://svn.apache.org/viewvc?rev=597042&view=rev o Normalize the URL to remove extra slashes. o Thanks to YunFeng Ma for pointing to the patch under GERONIMO-3583 .
          Hide
          Vamsavardhana Reddy added a comment -

          Part 2 in the issue description is to be addressed in documentation.

          Show
          Vamsavardhana Reddy added a comment - Part 2 in the issue description is to be addressed in documentation.

            People

            • Assignee:
              Vamsavardhana Reddy
              Reporter:
              Vamsavardhana Reddy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development