Geronimo
  1. Geronimo
  2. GERONIMO-3611

Deployer should provide an "install-library" option to upload jars to repository

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: deployment, usability
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Currently the only way to upload a library jar into repo is by using Common Libs portlet in Admin Console. Adding an "install-library" option to deployer should be helpful in uploading dependency jars to server's repo.

      1. GERONIMO-3611.patch
        27 kB
        Vamsavardhana Reddy
      2. GERONIMO-3611-2.0.patch
        26 kB
        Vamsavardhana Reddy
      3. GERONIMO-3611-new.patch
        18 kB
        Vamsavardhana Reddy
      4. GERONIMO-3611-new-2.0.patch
        18 kB
        Vamsavardhana Reddy

        Activity

        Hide
        Vamsavardhana Reddy added a comment -

        GERONIMO-3611-2.0.patch: For branches\2.0

        With this patch, the deployer supports an "install-library" option.

        Example:
        1. deploy.bat install-library --groupId mygrp mylib-1.0.jar
        will install the jar at repo/mygrp/mylib/1.0/mylib-1.0.jar

        2. deploy.bat install-library mylib-1.0.jar
        will install the jar at repo/default/mylib/1.0/mylib-1.0.jar

        Show
        Vamsavardhana Reddy added a comment - GERONIMO-3611 -2.0.patch: For branches\2.0 With this patch, the deployer supports an "install-library" option. Example: 1. deploy.bat install-library --groupId mygrp mylib-1.0.jar will install the jar at repo/mygrp/mylib/1.0/mylib-1.0.jar 2. deploy.bat install-library mylib-1.0.jar will install the jar at repo/default/mylib/1.0/mylib-1.0.jar
        Hide
        Vamsavardhana Reddy added a comment -

        GERONIMO-3611.patch: For trunk.

        Show
        Vamsavardhana Reddy added a comment - GERONIMO-3611 .patch: For trunk.
        Hide
        Vamsavardhana Reddy added a comment -

        The patch provided adds some new classes. Please review the code and let me know if it should be done differently.

        Show
        Vamsavardhana Reddy added a comment - The patch provided adds some new classes. Please review the code and let me know if it should be done differently.
        Hide
        Jacek Laskowski added a comment -

        I skimmed over it and it looks fine to me. Go and commit it if it doesn't break the build. I need it for my articles about Geronimo

        Show
        Jacek Laskowski added a comment - I skimmed over it and it looks fine to me. Go and commit it if it doesn't break the build. I need it for my articles about Geronimo
        Hide
        David Jencks added a comment -

        I think we should investigate whether the new functionality can be added to PluginInstallerGBean. That already has a reference to a Repository the artifact can go into which would avoid a lot of the complications with finding a correct repo from a config store, which is not always possible.

        Show
        David Jencks added a comment - I think we should investigate whether the new functionality can be added to PluginInstallerGBean. That already has a reference to a Repository the artifact can go into which would avoid a lot of the complications with finding a correct repo from a config store, which is not always possible.
        Hide
        Vamsavardhana Reddy added a comment -

        GERONIMO-3611-new.patch:

        As suggested by djencks, added the function to PluginInstaller instead of assuming the ConfigStore is backed by a Repository.

        Show
        Vamsavardhana Reddy added a comment - GERONIMO-3611 -new.patch: As suggested by djencks, added the function to PluginInstaller instead of assuming the ConfigStore is backed by a Repository.
        Hide
        Vamsavardhana Reddy added a comment -

        GERONIMO-3611-new-2.0.patch: For branches\2.0

        Show
        Vamsavardhana Reddy added a comment - GERONIMO-3611 -new-2.0.patch: For branches\2.0
        Hide
        Vamsavardhana Reddy added a comment -

        Completed: At revision: 597690 in branches\2.0 and trunk.
        o Deployer util now supports an "install-library" option.
        o Added an installLibrary method to PluginInstaller.
        o Thanks to David Jencks for his suggestion.

        Show
        Vamsavardhana Reddy added a comment - Completed: At revision: 597690 in branches\2.0 and trunk. o Deployer util now supports an "install-library" option. o Added an installLibrary method to PluginInstaller. o Thanks to David Jencks for his suggestion.

          People

          • Assignee:
            Vamsavardhana Reddy
            Reporter:
            Vamsavardhana Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development