Geronimo
  1. Geronimo
  2. GERONIMO-3575

Review CertificatePropertiesFileLoginModule

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: None
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Review CertificatePropertiesFileLoginModule for potential violations and security risks.

        Activity

        Hide
        Vamsavardhana Reddy added a comment -

        At revision: 590859 http://svn.apache.org/viewvc?rev=590859&view=rev
        o Added tests to check normal login and bad logins

        Show
        Vamsavardhana Reddy added a comment - At revision: 590859 http://svn.apache.org/viewvc?rev=590859&view=rev o Added tests to check normal login and bad logins
        Hide
        Vamsavardhana Reddy added a comment -

        At revision: 590862 http://svn.apache.org/viewvc?view=rev&revision=590862
        o LoginModule should not add principals when login fails. Added a test to detect if it does.
        o Other changes to bring CertificatePropertiesFileLoginModule in line with http://java.sun.com/j2se/1.5.0/docs/guide/security/jaas/JAASLMDevGuide.html

        **: This fix can use a thorough review.

        Show
        Vamsavardhana Reddy added a comment - At revision: 590862 http://svn.apache.org/viewvc?view=rev&revision=590862 o LoginModule should not add principals when login fails. Added a test to detect if it does. o Other changes to bring CertificatePropertiesFileLoginModule in line with http://java.sun.com/j2se/1.5.0/docs/guide/security/jaas/JAASLMDevGuide.html **: This fix can use a thorough review.
        Hide
        Vamsavardhana Reddy added a comment -

        I guess I am done with my review. Can someone review the code in the current state and comment?

        Show
        Vamsavardhana Reddy added a comment - I guess I am done with my review. Can someone review the code in the current state and comment?

          People

          • Assignee:
            Vamsavardhana Reddy
            Reporter:
            Vamsavardhana Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development