Review LDAPLoginModule for potential violations and security risks.
At revision: 590821 http://svn.apache.org/viewvc?view=rev&revision=590821
o LoginModule should not add principals when login fails.
o Other changes to bring PropertiesFileLoginModule in line with http://java.sun.com/j2se/1.5.0/docs/guide/security/jaas/JAASLMDevGuide.html
**: This fix can use a thorough review.
A test has NOT been added for the condition "LoginModule should not add principals when login fails".
I guess I am done with my review. Can someone review the code in the current state and comment?
Hmm... I am making mistakes in entering svn comments!! I guess I should take a break now