Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: security
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Review LDAPLoginModule for potential violations and security risks.

        Activity

        Hide
        Vamsavardhana Reddy added a comment -

        At revision: 590821 http://svn.apache.org/viewvc?view=rev&revision=590821
        o LoginModule should not add principals when login fails.
        o Other changes to bring PropertiesFileLoginModule in line with http://java.sun.com/j2se/1.5.0/docs/guide/security/jaas/JAASLMDevGuide.html
        **: This fix can use a thorough review.

        A test has NOT been added for the condition "LoginModule should not add principals when login fails".

        Show
        Vamsavardhana Reddy added a comment - At revision: 590821 http://svn.apache.org/viewvc?view=rev&revision=590821 o LoginModule should not add principals when login fails. o Other changes to bring PropertiesFileLoginModule in line with http://java.sun.com/j2se/1.5.0/docs/guide/security/jaas/JAASLMDevGuide.html **: This fix can use a thorough review. A test has NOT been added for the condition "LoginModule should not add principals when login fails".
        Hide
        Vamsavardhana Reddy added a comment -

        I guess I am done with my review. Can someone review the code in the current state and comment?

        Show
        Vamsavardhana Reddy added a comment - I guess I am done with my review. Can someone review the code in the current state and comment?
        Hide
        Vamsavardhana Reddy added a comment -

        Hmm... I am making mistakes in entering svn comments!! I guess I should take a break now

        Show
        Vamsavardhana Reddy added a comment - Hmm... I am making mistakes in entering svn comments!! I guess I should take a break now

          People

          • Assignee:
            Vamsavardhana Reddy
            Reporter:
            Vamsavardhana Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development