[GERONIMO-2809] TransactionManagerImpl.getTransactionStatus() shouldn't throw on no tx (with patch)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0-M5
• Fix Version/s: 2.0-M5
• Component/s: transaction manager
• Security Level: public (Regular issues)
• Patch Info: Patch Available
• Assignee: David Jencks
• Reporter: Andrus Adamchik
• Created: 07/Feb/07 14:08
• Updated: 11/Feb/07 23:41
• Resolved: 11/Feb/07 23:41

Description

org.apache.geronimo.transaction.manager.TransactionManagerImpl, implementation of "TransactionSynchronizationRegistry.getTransactionStatus()" method throws an IllegalStateException when called outside of active transaction. I believe this behavior is wrong. According to JTA javadocs:

"int getTransactionStatus()
Return the status of the transaction bound to the current thread at the time this method is called. This is the result of executing TransactionManager.getStatus() in the context of the transaction bound to the current thread at the time this method is called.
Returns: the status of the transaction bound to the current thread at the time this method is called."

So no exception is specified in the spec. Also current behavior caused grief when implementing a JPA provider. Most methods on the EntityManager have this note: "throws TransactionRequiredException if invoked on a container-managed entity manager of type PersistenceContextType.TRANSACTION and there is no transaction.", but currently the provider can't even check the tx status consistently, since this unexpected exception is thrown.

See attached patch for the trivial fix.