[GEOMETRY-86] Point2S.antipodal() or Point2S.from() is incorrect.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Baljit Singh
• Created: 08/Jan/20 01:25
• Updated: 21/Aug/21 03:45
• Resolved: 08/Feb/20 11:24

Description

    @Test
    public void testAntipodal() {
        Point2S point = Point2S.of(1.0, 1.0);
        Point2S antipodal = point.antipodal();
        Point2S fromNeg = Point2S.from(point.getVector().negate());

        System.out.println(String.format("Point2S: %s, Vector: %s", point, point.getVector()));
        System.out.println(String.format("Point2S: %s, Vector: %s", antipodal, antipodal.getVector()));
        System.out.println(String.format("Point2S: %s, Vector: %s", fromNeg, fromNeg.getVector()));
    }

This prints:
Point2S: (1.0, 1.0), Vector: (0.4546487134128409, 0.7080734182735712, 0.5403023058681398)
Point2S: (5.283185307179586, 2.141592653589793), Vector: (-0.4546487134128409, -0.7080734182735712, -0.5403023058681398)
Point2S: (4.141592653589792, 2.141592653589793), Vector: (-0.4546487134128409, -0.7080734182735712, -0.5403023058681398)

SphericalTestUtils.assertPointsEq does not detect the error because the point.getVector() and copy.getVector() are equal, and therefore the distance between these points is 0.

Issue Links

• links to: GitHub Pull Request #53