[GEODE-9390] DistributedSystem nodes is counted twice on each server member

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.15.0
• Component/s: membership
• Labels: pull-request-available
• Assignee: Matthew Reddington
• Reporter: Barrett Oglesby
• Created: 21/Jun/21 20:01
• Updated: 22/Jun/22 20:46
• Resolved: 04/May/22 23:21

Description

Once in ClusterDistributionManager.startThreads:

[warn 2021/06/20 16:20:16.152 HST server-1 <main> tid=0x1] ClusterDistributionManager.handleManagerStartup id=192.168.1.8(server-1:58386)<v1>:41001; kind=10

[warn 2021/06/20 16:20:16.153 HST server-1 <main> tid=0x1] DistributionStats.incNodes nodes=1
java.lang.Exception
	at org.apache.geode.distributed.internal.DistributionStats.incNodes(DistributionStats.java:1362)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.handleManagerStartup(ClusterDistributionManager.java:1809)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.addNewMember(ClusterDistributionManager.java:1062)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.startThreads(ClusterDistributionManager.java:691)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.<init>(ClusterDistributionManager.java:504)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:326)
	at org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:780)

And once in ClusterDistributionManager.create:

[warn 2021/06/20 16:20:16.155 HST server-1 <main> tid=0x1] ClusterDistributionManager.handleManagerStartup id=192.168.1.8(server-1:58386)<v1>:41001; kind=10

[warn 2021/06/20 16:20:16.156 HST server-1 <main> tid=0x1] DistributionStats.incNodes nodes=2
java.lang.Exception
	at org.apache.geode.distributed.internal.DistributionStats.incNodes(DistributionStats.java:1362)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.handleManagerStartup(ClusterDistributionManager.java:1809)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.addNewMember(ClusterDistributionManager.java:1062)
	at org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:354)
	at org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:780)

Issue Links

• links to: GitHub Pull Request #7639